Skip to content

WIP: Add myself as upgrade CI content approver #33903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
petr-muller wants to merge 6 commits into from
Closed

WIP: Add myself as upgrade CI content approver #33903

petr-muller wants to merge 6 commits into from

Conversation

@petr-muller
Copy link
Member

@petr-muller petr-muller commented Nov 9, 2022 •
edited
Loading

WIP: Builds over #33761..

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 9, 2022

@petr-muller: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-multiarch-master-nightly-4.13-ocp-e2e-aws-ovn-heterogeneous-upgrade N/A periodic Periodic changed
periodic-ci-openshift-multiarch-master-nightly-4.12-upgrade-from-stable-4.11-ocp-e2e-aws-heterogeneous-upgrade N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.13-multi-nightly-e2e-aws-ipi-p2 N/A periodic Registry content changed
periodic-ci-openshift-multiarch-master-nightly-4.12-upgrade-from-nightly-4.11-ocp-e2e-aws-heterogeneous-upgrade N/A periodic Periodic changed
periodic-ci-openshift-multiarch-master-nightly-4.12-upgrade-from-stable-4.11-ocp-e2e-aws-sdn-arm64 N/A periodic Ci-operator config changed
periodic-ci-openshift-multiarch-master-nightly-4.13-upgrade-from-nightly-4.12-ocp-e2e-aws-sdn-arm64 N/A periodic Ci-operator config changed
periodic-ci-openshift-multiarch-master-nightly-4.13-upgrade-from-nightly-4.12-ocp-e2e-aws-heterogeneous-upgrade N/A periodic Periodic changed
periodic-ci-openshift-multiarch-master-nightly-4.11-ocp-e2e-aws-ovn-heterogeneous-upgrade N/A periodic Periodic changed
periodic-ci-openshift-multiarch-master-nightly-4.13-upgrade-from-stable-4.12-ocp-e2e-aws-sdn-arm64 N/A periodic Ci-operator config changed
periodic-ci-openshift-multiarch-master-nightly-4.12-upgrade-from-nightly-4.11-ocp-e2e-aws-sdn-arm64 N/A periodic Ci-operator config changed
periodic-ci-openshift-multiarch-master-nightly-4.12-upgrade-from-nightly-4.11-ocp-ovn-remote-libvirt-ppc64le N/A periodic Ci-operator config changed
periodic-ci-openshift-multiarch-master-nightly-4.13-upgrade-from-stable-4.12-ocp-e2e-aws-heterogeneous-upgrade N/A periodic Periodic changed
periodic-ci-openshift-multiarch-master-nightly-4.12-ocp-e2e-aws-ovn-heterogeneous-upgrade N/A periodic Periodic changed
periodic-ci-openshift-multiarch-master-nightly-4.13-upgrade-from-nightly-4.12-ocp-ovn-remote-libvirt-s390x N/A periodic Ci-operator config changed
periodic-ci-openshift-multiarch-master-nightly-4.12-upgrade-from-nightly-4.11-ocp-ovn-remote-libvirt-s390x N/A periodic Ci-operator config changed
periodic-ci-openshift-multiarch-master-nightly-4.13-upgrade-from-nightly-4.12-ocp-ovn-remote-libvirt-ppc64le N/A periodic Ci-operator config changed
periodic-ci-openshift-multiarch-master-nightly-4.12-ocp-e2e-aws-ovn-heterogeneous N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@petr-muller
multiarch: add scaffolding for hetero->hetero upgrade jobs
1a05f62
@petr-muller
heterogeneous: remove unnecessary code
27d24e7 
- `$KUBECONFIG` is set by ci-operator
- Console URL extraction only needs to be done by steps that *install* a
  cluster
@petr-muller
make update
d0f63bd
@petr-muller
Introduce a shared heterogenenous upgrade workflow
3f81700
@petr-muller
Improve heterogeneous install workflow description
39b43b9
@petr-muller
Add myself as upgrade CI content owner
7b4f31e 
...and fixup heterogeneous workflow `OWNERS` file to be a symlink, like
all others.
@petr-muller petr-muller force-pushed the muller-as-upgrade-owner branch from bfd28b2 to 7b4f31e Compare November 9, 2022 16:08
@petr-muller petr-muller changed the title Add myself as upgrade CI content approver WIP: Add myself as upgrade CI content approver Nov 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-muller
Once this PR has been reviewed and has the lgtm label, please assign deepsm007, jluhrsen for approval by writing /assign @deepsm007 @jluhrsen in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-muller
Once this PR has been reviewed and has the lgtm label, please assign deepsm007, jluhrsen for approval by writing /assign @deepsm007 @jluhrsen in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@petr-muller @openshift-ci-robot