Skip to content

[nutanix] add e2e-nutanix as presubmit for machine-api-operator #33027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Oct 12, 2022
Merged

[nutanix] add e2e-nutanix as presubmit for machine-api-operator #33027

openshift-merge-robot merged 2 commits into from
Oct 12, 2022

Conversation

@rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Oct 11, 2022 •
edited
Loading

adds e2e-nutanix to the machine-api-operator and machine-api-provider-nutanix repositories

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Oct 11, 2022

/test pj-rehearse

@rvanderp3 rvanderp3 marked this pull request as ready for review October 11, 2022 13:22
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2022
@openshift-ci openshift-ci bot requested review from Fedosin and JoelSpeed October 11, 2022 13:24
@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Oct 11, 2022

/assign @JoelSpeed
cc: @elmiko

@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Oct 11, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2022
@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Oct 11, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2022
@lobziik
Copy link
Contributor

lobziik commented Oct 11, 2022

/approve

elmiko
elmiko reviewed Oct 11, 2022
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 11, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 11, 2022

/retest-required

Remaining retests: 0 against base HEAD c9fa126 and 2 for PR HEAD 36ffc48fd46274a2b7873044ec24ba9fbd73a68d in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 11, 2022

/retest-required

Remaining retests: 0 against base HEAD ef3b2bc and 1 for PR HEAD 36ffc48fd46274a2b7873044ec24ba9fbd73a68d in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 11, 2022

/retest-required

Remaining retests: 0 against base HEAD 440fad8 and 0 for PR HEAD 36ffc48fd46274a2b7873044ec24ba9fbd73a68d in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2022
@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Oct 12, 2022

rebased

@lobziik
Copy link
Contributor

lobziik commented Oct 12, 2022

/test pj-rehearse

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 12, 2022

/test pj-rehearse

@elmiko
Copy link
Contributor

elmiko commented Oct 12, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, lobziik, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3066709 into openshift:master Oct 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2022

@rvanderp3: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-api-operator-master.yaml using file ci-operator/config/openshift/machine-api-operator/openshift-machine-api-operator-master.yaml
    • key openshift-machine-api-provider-nutanix-main.yaml using file ci-operator/config/openshift/machine-api-provider-nutanix/openshift-machine-api-provider-nutanix-main.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-api-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-api-operator/openshift-machine-api-operator-master-presubmits.yaml
    • key openshift-machine-api-provider-nutanix-main-presubmits.yaml using file ci-operator/jobs/openshift/machine-api-provider-nutanix/openshift-machine-api-provider-nutanix-main-presubmits.yaml
Details

In response to this:

adds e2e-nutanix to the machine-api-operator and machine-api-provider-nutanix repositories

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lobziik lobziik mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fedosin Fedosin Awaiting requested review from Fedosin

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

1 more reviewer

@elmiko elmiko elmiko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@elmiko elmiko

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rvanderp3 @lobziik @openshift-ci-robot @JoelSpeed @elmiko @openshift-merge-robot