Skip to content

Conversation

@cjschaef
Copy link
Member

While attempting to add retries to ibmcloud CLI commands, creation of a temporary file to store results fails due to the filepath of the ibmcloud CLI command, requiring removal of the filepath to address.

Related: https://issues.redhat.com/browse/OCPBUGS-706

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 12, 2022
@openshift-ci-robot
Copy link
Contributor

@cjschaef: This pull request references Jira Issue OCPBUGS-706, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

While attempting to add retries to ibmcloud CLI commands, creation of a temporary file to store results fails due to the filepath of the ibmcloud CLI command, requiring removal of the filepath to address.

Related: https://issues.redhat.com/browse/OCPBUGS-706

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cjschaef cjschaef force-pushed the ocpbugs-706 branch 2 times, most recently from 64eb4a9 to 31e7a6e Compare September 12, 2022 20:36
@cjschaef
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2022
@cjschaef
Copy link
Member Author

/retest

@cjschaef
Copy link
Member Author

/retest

@cjschaef cjschaef force-pushed the ocpbugs-706 branch 2 times, most recently from fe8f8e1 to f8bfca3 Compare September 14, 2022 13:31
@cjschaef
Copy link
Member Author

/hold cancel
/retitle IBMCloud: File cli temp file

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@openshift-ci openshift-ci bot changed the title OCPBUGS-706: IBMCloud: File cli temp file IBMCloud: File cli temp file Sep 14, 2022
@rvanderp3
Copy link
Contributor

/jira refresh

@rvanderp3
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
While attempting to add retries to ibmcloud CLI commands,
creation of a temporary file to store results fails due to
the filepath of the ibmcloud CLI command, requiring removal
of the filepath to address. Remove use of grep for filtering
resources, to prevent failures when nothing is found.
Also, update approvers and reviewers for ibmcloud owners.

Related: https://issues.redhat.com/browse/OCPBUGS-706
@cjschaef
Copy link
Member Author

/test pj-rehease

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

@cjschaef: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build-clusters
  • /test build01-dry
  • /test build02-dry
  • /test build03-dry
  • /test build04-dry
  • /test build05-dry
  • /test check-gh-automation
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-bootstrap-config-validation
  • /test ci-testgrid-allow-list
  • /test config
  • /test core-valid
  • /test correctly-sharded-config
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test hive-dry
  • /test jira-lifecycle-config
  • /test openshift-image-mirror-mappings
  • /test ordered-prow-config
  • /test owners
  • /test pj-rehearse-blocking
  • /test pr-reminder-config
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test pylint
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test sync-rover-groups
  • /test yamllint

The following commands are available to trigger optional jobs:

  • /test arm01-dry
  • /test pj-rehearse
  • /test pj-rehearse-max
  • /test pj-rehearse-more
  • /test vsphere-dry

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-release-master-build-clusters
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-pj-rehearse
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-openshift-image-mirror-mappings
  • pull-ci-openshift-release-yamllint
Details

In response to this:

/test pj-rehease

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cjschaef
Copy link
Member Author

/test pj-rehearse

@cjschaef
Copy link
Member Author

Trying to get one of the rehearse jobs to re-run (MAPI, CAPI, or release e2e), since they haven't triggered with recent changes so far.
/test all

@cjschaef
Copy link
Member Author

ibmcloud-gather-resources has run successfully now

 INFO[2022-09-14T16:53:20Z] Running step e2e-ibmcloud-ipi-ibmcloud-gather-resources. 
INFO[2022-09-14T16:57:00Z] Step e2e-ibmcloud-ipi-ibmcloud-gather-resources succeeded after 3m40s. 

Things appear to be working properly, at least when IPI install succeeds. I'll have to confirm later in cases where IPI install fails to create some/all resources.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

@cjschaef: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/machine-api-provider-ibmcloud/main/e2e-ibmcloud 31e7a6ef3b111ce0f5b5758a9beacd36082ce4a6 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-api-provider-ibmcloud/main/e2e-ibmcloud 6d2aebe link unknown /test pj-rehearse
ci/prow/pj-rehearse 6d2aebe link false /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rvanderp3
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@cjschaef
Copy link
Member Author

cluster-api-provider-ibmcloud/main/e2e-ibmcloud is affected by OCPBUGS-1327

NAME                                        STATUS   ROLES                  AGE   VERSION           INTERNAL-IP    EXTERNAL-IP    OS-IMAGE                                                        KERNEL-VERSION                 CONTAINER-RUNTIME
ci-op-sgbrhc5c-4e03e-bszh6-master-0         Ready    control-plane,master   49m   v1.24.0+ebabf6d   10.242.1.5     10.242.1.5     Red Hat Enterprise Linux CoreOS 412.86.202209121449-0 (Ootpa)   4.18.0-372.19.1.el8_6.x86_64   cri-o://1.25.0-51.rhaos4.12.git315a0cb.el8
ci-op-sgbrhc5c-4e03e-bszh6-master-1         Ready    control-plane,master   48m   v1.24.0+ebabf6d   10.242.65.6    10.242.65.6    Red Hat Enterprise Linux CoreOS 412.86.202209121449-0 (Ootpa)   4.18.0-372.19.1.el8_6.x86_64   cri-o://1.25.0-51.rhaos4.12.git315a0cb.el8
ci-op-sgbrhc5c-4e03e-bszh6-master-2         Ready    control-plane,master   49m   v1.24.0+ebabf6d   10.242.128.6   10.242.128.6   Red Hat Enterprise Linux CoreOS 412.86.202209121449-0 (Ootpa)   4.18.0-372.19.1.el8_6.x86_64   cri-o://1.25.0-51.rhaos4.12.git315a0cb.el8
ci-op-sgbrhc5c-4e03e-bszh6-worker-2-vn5tq   Ready    worker                 40m   v1.24.0+ebabf6d   10.242.64.4    10.242.64.4    Red Hat Enterprise Linux CoreOS 412.86.202209121449-0 (Ootpa)   4.18.0-372.19.1.el8_6.x86_64   cri-o://1.25.0-51.rhaos4.12.git315a0cb.el8
ci-op-sgbrhc5c-4e03e-bszh6-worker-3-dl66q   Ready    worker                 40m   v1.24.0+ebabf6d   10.242.129.4   10.242.129.4   Red Hat Enterprise Linux CoreOS 412.86.202209121449-0 (Ootpa)   4.18.0-372.19.1.el8_6.x86_64   cri-o://1.25.0-51.rhaos4.12.git315a0cb.el8
# ibmcloud is instances

0787_69362abe-ddbf-4b60-b367-a873d8da58e3   ci-op-sgbrhc5c-4e03e-bszh6-master-0         running   10.242.1.5     -             bx2-4x16   ci-op-sgbrhc5c-4e03e-bszh6-rhcos   ci-op-sgbrhc5c-4e03e-bszh6-vpc   eu-gb-1   ci-op-sgbrhc5c-4e03e-bszh6   
0787_ff0b7b80-96a9-4bd9-954c-f95bec693490   ci-op-sgbrhc5c-4e03e-bszh6-worker-1-h67rq   running   10.242.0.4     -             bx2-4x16   ci-op-sgbrhc5c-4e03e-bszh6-rhcos   ci-op-sgbrhc5c-4e03e-bszh6-vpc   eu-gb-1   ci-op-sgbrhc5c-4e03e-bszh6   
0797_a0d0d1a8-a4cf-4012-8269-70b2a9f5223d   ci-op-sgbrhc5c-4e03e-bszh6-master-1         running   10.242.65.6    -             bx2-4x16   ci-op-sgbrhc5c-4e03e-bszh6-rhcos   ci-op-sgbrhc5c-4e03e-bszh6-vpc   eu-gb-2   ci-op-sgbrhc5c-4e03e-bszh6   
0797_e6a18cb1-27d7-4a24-b17d-a86f8146fc58   ci-op-sgbrhc5c-4e03e-bszh6-worker-2-vn5tq   running   10.242.64.4    -             bx2-4x16   ci-op-sgbrhc5c-4e03e-bszh6-rhcos   ci-op-sgbrhc5c-4e03e-bszh6-vpc   eu-gb-2   ci-op-sgbrhc5c-4e03e-bszh6   
07a7_5153b815-e76e-4d04-8219-9adaf954770d   ci-op-sgbrhc5c-4e03e-bszh6-master-2         running   10.242.128.6   -             bx2-4x16   ci-op-sgbrhc5c-4e03e-bszh6-rhcos   ci-op-sgbrhc5c-4e03e-bszh6-vpc   eu-gb-3   ci-op-sgbrhc5c-4e03e-bszh6   
07a7_b06f7710-f3ec-4429-a119-4d2749995eeb   ci-op-sgbrhc5c-4e03e-bszh6-worker-3-dl66q   running   10.242.129.4   -             bx2-4x16   ci-op-sgbrhc5c-4e03e-bszh6-rhcos   ci-op-sgbrhc5c-4e03e-bszh6-vpc   eu-gb-3   ci-op-sgbrhc5c-4e03e-bszh6   

This does appear to resolve the issue with ibmcloud-gather-resources as expected

 INFO[2022-09-14T16:53:20Z] Running step e2e-ibmcloud-ipi-ibmcloud-gather-resources. 
INFO[2022-09-14T16:57:00Z] Step e2e-ibmcloud-ipi-ibmcloud-gather-resources succeeded after 3m40s. 

@cjschaef
Copy link
Member Author

/assign @bear-redhat

@jeffnowicki
Copy link

/jira refresh

@jeffnowicki
Copy link

/retitle OCPBUGS-706: IBMCloud: File cli temp file IBMCloud: File cli temp

@openshift-ci openshift-ci bot changed the title IBMCloud: File cli temp file OCPBUGS-706: IBMCloud: File cli temp file IBMCloud: File cli temp Sep 20, 2022
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 20, 2022
@openshift-ci-robot
Copy link
Contributor

@cjschaef: This pull request references Jira Issue OCPBUGS-706, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @MayXuQQ

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

While attempting to add retries to ibmcloud CLI commands, creation of a temporary file to store results fails due to the filepath of the ibmcloud CLI command, requiring removal of the filepath to address.

Related: https://issues.redhat.com/browse/OCPBUGS-706

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from MayXuQQ September 20, 2022 18:43
@jeffnowicki
Copy link

/retitle OCPBUGS-706: IBMCloud: File cli temp file

@openshift-ci openshift-ci bot changed the title OCPBUGS-706: IBMCloud: File cli temp file IBMCloud: File cli temp OCPBUGS-706: IBMCloud: File cli temp file Sep 20, 2022
Copy link
Contributor

@MayXuQQ MayXuQQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bear-redhat
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bear-redhat, cjschaef, MayXuQQ, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2022
@openshift-merge-robot openshift-merge-robot merged commit 2980af5 into openshift:master Sep 21, 2022
@openshift-ci-robot
Copy link
Contributor

@cjschaef: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-706 has been moved to the MODIFIED state.

Details

In response to this:

While attempting to add retries to ibmcloud CLI commands, creation of a temporary file to store results fails due to the filepath of the ibmcloud CLI command, requiring removal of the filepath to address.

Related: https://issues.redhat.com/browse/OCPBUGS-706

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cjschaef cjschaef deleted the ocpbugs-706 branch September 21, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants