Skip to content

Conversation

@lihongan
Copy link
Contributor

@lihongan lihongan commented Sep 2, 2022

No description provided.

@jianli-wei
Copy link
Contributor

jianli-wei commented Sep 2, 2022

@lihongan Forgive me, I'm unfamiliar with SDN. Two questions, thanks in advance!

  1. oc get networks.config.openshift.io cluster -oyaml (in cucushift-installer-check build logs) tells networkType: OVNKubernetes, is it expected?
  2. It's said the default value for networking.networkType is OpenShiftSDN (e.g. 4.11 doc). Why do we need to set it explicitly?

BTW, please give some description for the PR, thanks!

@lihongan
Copy link
Contributor Author

lihongan commented Sep 2, 2022

@lihongan Forgive me, I'm unfamiliar with SDN. Two questions, thanks in advance!

1. `oc get networks.config.openshift.io cluster -oyaml` (in `cucushift-installer-check` [build logs](https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/31929/rehearse-31929-periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-gcp/1565550174380494848/artifacts/installer-rehearse-gcp/cucushift-installer-check/build-log.txt)) tells `networkType: OVNKubernetes`, is it expected?

2. It's said the default value for `networking.networkType` is `OpenShiftSDN` (e.g. [4.11 doc](https://docs.openshift.com/container-platform/4.11/installing/installing_gcp/installing-gcp-customizations.html#installation-configuration-parameters-network_installing-gcp-customizations)). Why do we need to set it explicitly?

BTW, please give some description for the PR, thanks!

@jianli-wei These workflows are for 4.12 and later version since from 4.12 the default value is OVN, more details please see https://issues.redhat.com/browse/OCPQE-10828

And for the 1st question, it is not expected and I need a further investigation. Thanks.

@lihongan
Copy link
Contributor Author

lihongan commented Sep 2, 2022

for the update of vsphere part, it is from #31841 (comment)

@lihongan
Copy link
Contributor Author

lihongan commented Sep 2, 2022

/assign @jianlinliu
All look good now and SDN is set as expected.

cc @zhaozhanqi @anuragthehatter

@zhaozhanqi
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2022
- ref: upi-conf-gcp
- ref: upi-install-gcp
- ref: ipi-install-times-collection
- ref: enable-qe-catalogsource
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, ref: enable-qe-catalogsource is added.

@lihongan
Copy link
Contributor Author

lihongan commented Sep 5, 2022

azure job failed

level=error msg=failed to initialize the cluster: Cluster operators authentication, console, dns, image-registry, ingress, machine-api, monitoring are not available

@lihongan
Copy link
Contributor Author

lihongan commented Sep 5, 2022

/retest

@jianlinliu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianlinliu, lihongan, zhaozhanqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2022

@lihongan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d65def0 into openshift:master Sep 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2022

@lihongan: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-verification-tests-master__installer-rehearse-4.12.yaml using file ci-operator/config/openshift/verification-tests/openshift-verification-tests-master__installer-rehearse-4.12.yaml
  • job-config-master-periodics configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-verification-tests-master-periodics.yaml using file ci-operator/jobs/openshift/verification-tests/openshift-verification-tests-master-periodics.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lihongan lihongan deleted the private-sdn branch September 7, 2022 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants