Skip to content

Conversation

@QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Sep 1, 2022

Upgrade to go 1.18, openshift/runtime-utils#15
failed the ci since go is out of date.

Signed-off-by: Qi Wang [email protected]

Upgrade to go 1.18, openshift/runtime-utils#15
failed the ci since go is out of date.

Signed-off-by: Qi Wang <[email protected]>
@QiWang19 QiWang19 force-pushed the runtimeutils-ci-go-version branch from 6d87cff to 7d540a3 Compare September 1, 2022 20:10
@QiWang19 QiWang19 changed the title Update go 1.19 of runtime-utils ci Update go version of runtime-utils ci Sep 1, 2022
@QiWang19
Copy link
Member Author

QiWang19 commented Sep 1, 2022

/assign @adambkaplan

@QiWang19
Copy link
Member Author

QiWang19 commented Sep 1, 2022

@adambkaplan could you merge this, I think this can fix tests of this pr openshift/runtime-utils#15

@rphillips
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2022
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@coreydaley you should replace me in the OWNERS file.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, QiWang19, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2022

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2f35a72 into openshift:master Sep 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2022

@QiWang19: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-runtime-utils-master.yaml using file ci-operator/config/openshift/runtime-utils/openshift-runtime-utils-master.yaml
  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-runtime-utils-release-4.12.yaml using file ci-operator/config/openshift/runtime-utils/openshift-runtime-utils-release-4.12.yaml
Details

In response to this:

Upgrade to go 1.18, openshift/runtime-utils#15
failed the ci since go is out of date.

Signed-off-by: Qi Wang [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants