Skip to content

Conversation

@cgwalters
Copy link
Member

Followup to openshift/os#940

We changed the image name, but to succeed in landing the MCO changes
to use rhel-coreos-8 we need an image named rhel-coreos-8 in
the integration imagestream.

Closes: openshift/os#943

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2022
@openshift-ci openshift-ci bot requested review from aaradhak and mike-nguyen August 5, 2022 17:52
Followup to openshift/os#940

We changed the image name, but to succeed in landing the MCO changes
to use `rhel-coreos-8` we need an image named `rhel-coreos-8` in
the integration imagestream.

Closes: openshift/os#943
@cgwalters cgwalters force-pushed the rhcos-promote-4.12 branch from 0660669 to b82a797 Compare August 5, 2022 18:10
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2022
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2022
@yuqi-zhang
Copy link
Contributor

/assign @jupierce

Since this does touch image-mirroring, it appears we need an owner from there to also take a look.

For context, this is changing how we ship base OS images in alignment with the CoreOS Layering enhancement. The original (machine-os-content) will still be shipped for compatibility, but we need 2 additional images (rhel coreos 8 and extensions) for the new layered container image os format.

@yuqi-zhang
Copy link
Contributor

/assign @bparees

is this something you can help us with? Sorry for the multi-pings. This is blocking the MCO team and the layering initiative. For more context please see the above message (and openshift/machine-config-operator#3258 (comment) )

@bparees
Copy link
Contributor

bparees commented Aug 9, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, cgwalters, jmarrero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2022

@cgwalters: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8c525fe into openshift:master Aug 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2022

@cgwalters: Updated the following 4 configmaps:

  • job-config-master-postsubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-os-master-postsubmits.yaml using file ci-operator/jobs/openshift/os/openshift-os-master-postsubmits.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-os-master-presubmits.yaml using file ci-operator/jobs/openshift/os/openshift-os-master-presubmits.yaml
  • image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:
    • key mapping_origin_4_12 using file core-services/image-mirroring/openshift/mapping_origin_4_12
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-os-master__periodic.yaml using file ci-operator/config/openshift/os/openshift-os-master__periodic.yaml
Details

In response to this:

Followup to openshift/os#940

We changed the image name, but to succeed in landing the MCO changes
to use rhel-coreos-8 we need an image named rhel-coreos-8 in
the integration imagestream.

Closes: openshift/os#943

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tag builds into oc -n ocp get is/4.12

6 participants