-
Notifications
You must be signed in to change notification settings - Fork 2.1k
openshift/os: Explicitly promote into ocp/4.12 imagestream #31118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openshift/os: Explicitly promote into ocp/4.12 imagestream #31118
Conversation
Followup to openshift/os#940 We changed the image name, but to succeed in landing the MCO changes to use `rhel-coreos-8` we need an image named `rhel-coreos-8` in the integration imagestream. Closes: openshift/os#943
0660669 to
b82a797
Compare
jmarrero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
/assign @jupierce Since this does touch image-mirroring, it appears we need an owner from there to also take a look. For context, this is changing how we ship base OS images in alignment with the CoreOS Layering enhancement. The original (machine-os-content) will still be shipped for compatibility, but we need 2 additional images (rhel coreos 8 and extensions) for the new layered container image os format. |
|
/assign @bparees is this something you can help us with? Sorry for the multi-pings. This is blocking the MCO team and the layering initiative. For more context please see the above message (and openshift/machine-config-operator#3258 (comment) ) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, cgwalters, jmarrero The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cgwalters: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@cgwalters: Updated the following 4 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Followup to openshift/os#940
We changed the image name, but to succeed in landing the MCO changes
to use
rhel-coreos-8we need an image namedrhel-coreos-8inthe integration imagestream.
Closes: openshift/os#943