Skip to content

openshift/os: Promote to rhel-coreos-8 #31084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-ci merged 1 commit into from
Aug 5, 2022
Merged

openshift/os: Promote to rhel-coreos-8 #31084

openshift-ci merged 1 commit into from
Aug 5, 2022

Conversation

@cgwalters
Copy link
Member

@cgwalters cgwalters commented Aug 4, 2022

The release payload name will be rhel-coreos-8, so let's have the CI config match.

I think this may unblock openshift/machine-config-operator#3258 (comment)

Closes: openshift/os#940

@cgwalters cgwalters mentioned this pull request Aug 4, 2022
Closed
@openshift-ci openshift-ci bot requested review from jlebon and marmijo August 4, 2022 19:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022
@cgwalters cgwalters force-pushed the ci-promote-to-rhel-coreos-8 branch 2 times, most recently from ab1b893 to ae81aa4 Compare August 4, 2022 21:18
@cgwalters
openshift/os: Promote to rhel-coreos-8
155245c 
The release payload name will be `rhel-coreos-8`, so let's have the CI config match.

I think this may unblock openshift/machine-config-operator#3258 (comment)

Closes: openshift/os#940
@cgwalters cgwalters force-pushed the ci-promote-to-rhel-coreos-8 branch from ae81aa4 to 155245c Compare August 4, 2022 21:44
@cgwalters
Copy link
Member Author

cgwalters commented Aug 4, 2022

OK right, though after this lands we'd need to set up automation which moves the rhel-coreos-8 image from the rhcos-devel namespace into the ocp/4:12 imagestream or so?

Or alternatively, make that the default, and then have a config which mirrors out back to rhcos-devel?

LorbusChris
LorbusChris suggested changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@LorbusChris LorbusChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

Please also add the same changes to the respective -4.12 and -4.13 files.

@travier
Copy link
Member

travier commented Aug 5, 2022

Same as Christian. LGTM but needs to be synced.

@cgwalters
Copy link
Member Author

cgwalters commented Aug 5, 2022

Hmm but wait there's only one -master periodic job right?

@travier
Copy link
Member

travier commented Aug 5, 2022

Oh indeed, my bad

@travier
Copy link
Member

travier commented Aug 5, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travier
Copy link
Member

travier commented Aug 5, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2022

@cgwalters: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 45ae59f into openshift:master Aug 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2022

@cgwalters: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-os-master__periodic.yaml using file ci-operator/config/openshift/os/openshift-os-master__periodic.yaml
  • job-config-master-postsubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-os-master-postsubmits.yaml using file ci-operator/jobs/openshift/os/openshift-os-master-postsubmits.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-os-master-presubmits.yaml using file ci-operator/jobs/openshift/os/openshift-os-master-presubmits.yaml
Details

In response to this:

The release payload name will be rhel-coreos-8, so let's have the CI config match.

I think this may unblock openshift/machine-config-operator#3258 (comment)

Closes: openshift/os#940

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlebon jlebon Awaiting requested review from jlebon

@marmijo marmijo Awaiting requested review from marmijo

2 more reviewers

@LorbusChris LorbusChris LorbusChris requested changes

@travier travier travier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LorbusChris LorbusChris

@travier travier

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change name of CI/Prow build to rhel-coreos-8

3 participants

@cgwalters @travier @LorbusChris