Skip to content

Conversation

@rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Jun 24, 2022

govc is being downloaded from github during the build of the installer UPI image. the github rate limit is impacting the ability of installer jobs to run. The intent of this PR is to mirror the VMware govc image containing the intended version of govc such that it can added to the installer UPI image build.

Impact: This issue is impacting the ability of the installer to build in CI

@jcpowermac
Copy link
Contributor

cc: @patrickdillon

@rvanderp3
Copy link
Contributor Author

/assign @jmguzik

@patrickdillon
Copy link
Contributor

I wonder if we can use this technique or something similar for the entire upi image... We frequently have issues such as this and it causes widespread failures on unrelated jobs

Copy link
Contributor

@bear-redhat bear-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a new line at the end of file?

@rvanderp3 rvanderp3 force-pushed the mirror-govc-image branch from 706ae3d to 3f9b8c5 Compare June 27, 2022 17:28
@rvanderp3
Copy link
Contributor Author

add a new line at the end of file?

Good catch @bear-redhat . Just made that update.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmguzik, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2022

@rvanderp3: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 2784e6e into openshift:master Jun 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2022

@rvanderp3: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_supplemental_ci_images_ci using file core-services/image-mirroring/supplemental-ci-images/mapping_supplemental_ci_images_ci
Details

In response to this:

govc is being downloaded from github during the build of the installer UPI image. the github rate limit is impacting the ability of installer jobs to run. The intent of this PR is to mirror the VMware govc image containing the intended version of govc such that it can added to the installer UPI image build.

Impact: This issue is impacting the ability of the installer to build in CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants