-
Notifications
You must be signed in to change notification settings - Fork 2.1k
mirror govc image to relieve github rate limit #29826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc: @patrickdillon |
|
/assign @jmguzik |
|
I wonder if we can use this technique or something similar for the entire upi image... We frequently have issues such as this and it causes widespread failures on unrelated jobs |
bear-redhat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a new line at the end of file?
706ae3d to
3f9b8c5
Compare
Good catch @bear-redhat . Just made that update. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmguzik, rvanderp3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@rvanderp3: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@rvanderp3: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
govc is being downloaded from github during the build of the installer UPI image. the github rate limit is impacting the ability of installer jobs to run. The intent of this PR is to mirror the VMware govc image containing the intended version of govc such that it can added to the installer UPI image build.
Impact: This issue is impacting the ability of the installer to build in CI