Skip to content

MCO: allow ssh #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Feb 8, 2019
Merged

MCO: allow ssh #2817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...or/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ build_root:
name: release
namespace: openshift
tag: golang-1.10
test_binary_build_commands: chmod uga+w /etc/passwd
Copy link
Member Author

@runcom runcom Feb 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, this was wrong, my understanding is that test_binary_build_commands is ran for the test-bin image but in e2e-aws-go we're not using test-bin (there's no container: from: test-bin). I don't believe we can use binary_build_commands as we don't seem to be using the bin image either afaict (just plan src) (for reference https://github.com/openshift/ci-operator/blob/master/CONFIGURATION.md#binary_build_commands)

not sure what to do actually, @stevekuznetsov @smarterclayton wdyt?

Copy link
Member Author

@runcom runcom Feb 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok we're using openshift_installer_src so we're using the src image by default anyway for e2e-aws-go, that's why chmod is not executed nor it would be using binary_build_commands.

Copy link
Member Author

@runcom runcom Feb 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meanwhile, #2819

tests:
- as: unit
commands: make test-unit
Expand All @@ -50,6 +51,7 @@ tests:
openshift_installer:
cluster_profile: aws
- as: e2e-aws-op
commands: make test-e2e
commands: echo "${USER:-default}:x:$(id -u):$(id -g):Default User:$HOME:/sbin/nologin"
>> /etc/passwd; make test-e2e
openshift_installer_src:
cluster_profile: aws
3 changes: 2 additions & 1 deletion ...penshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ presubmits:
- name: JOB_NAME_SAFE
value: e2e-aws-op
- name: TEST_COMMAND
value: make test-e2e
value: echo "${USER:-default}:x:$(id -u):$(id -g):Default User:$HOME:/sbin/nologin"
>> /etc/passwd; make test-e2e
image: ci-operator:latest
imagePullPolicy: Always
name: ""
Expand Down