Skip to content

golang-1.10/Dockerfile: add systemd-devel for MCO journal bindings #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 7, 2019
Merged

golang-1.10/Dockerfile: add systemd-devel for MCO journal bindings #2783

openshift-merge-robot merged 1 commit into from
Feb 7, 2019

Conversation

@runcom
Copy link
Member

@runcom runcom commented Feb 5, 2019

We're using the systemd journal bindings in the MCO and we need to pull in systemd-devel for C headers.
Ref: openshift/machine-config-operator#381 and openshift/machine-config-operator#335

/cc @cgwalters @jlebon

@stevekuznetsov @smarterclayton ptal

Signed-off-by: Antonio Murdaca [email protected]

@runcom runcom mentioned this pull request Feb 5, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2019
@runcom runcom force-pushed the add-systemd-devel branch from ff5cf58 to 5bfbaf6 Compare February 5, 2019 14:57
@jlebon
Copy link
Member

jlebon commented Feb 5, 2019

For more background/motivation: the MCD today essentially chroots into the mounted host's rootfs to perform operations there. Journal bindings means better host logs at the cluster level (e.g. openshift/machine-config-operator#335 simply proxies logs to the container so one doesn't need to ssh into the node to figure out why pivot failed).

@ashcrow
Copy link
Member

ashcrow commented Feb 5, 2019

/assign @bbguimaraes

@ashcrow
Copy link
Member

ashcrow commented Feb 5, 2019

/assign @stevekuznetsov

@cgwalters
Copy link
Member

cgwalters commented Feb 5, 2019

Huh, I hadn't realized the build image had accumulated a log of random dependencies; e.g. mercurial? Since we're shipping libvirt-devel here we might as well indeed ship systemd-devel.

@cgwalters
Copy link
Member

cgwalters commented Feb 5, 2019

/approve

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Feb 6, 2019

/retest

1 similar comment
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Feb 6, 2019

/retest

@jlebon jlebon mentioned this pull request Feb 6, 2019
Merged
@jlebon
Copy link
Member

jlebon commented Feb 6, 2019

Ping? 📞
Can we get someone to review this?

@ashcrow
Copy link
Member

ashcrow commented Feb 7, 2019

/assign @smarterclayton

@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 7, 2019

It’s not random, go uses it for go get.

If you have a legit need for systemd-devel it’s fine to add it. We used to have it for Kubelet until that code switched to pure go.

/approve

@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, runcom, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, runcom, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2019
@openshift-merge-robot openshift-merge-robot merged commit 2733daa into openshift:master Feb 7, 2019
@runcom runcom deleted the add-systemd-devel branch February 7, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@jlebon jlebon Awaiting requested review from jlebon

1 more reviewer

@ashcrow ashcrow ashcrow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bbguimaraes bbguimaraes

@smarterclayton smarterclayton

@stevekuznetsov stevekuznetsov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@runcom @jlebon @ashcrow @cgwalters @openshift-merge-robot @smarterclayton @openshift-ci-robot @bbguimaraes @stevekuznetsov