Skip to content

Conversation

@QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Apr 5, 2022

Update go version from 1.16 to 1.17.
openshift/runtime-utils#15 CI failed since the go is out of date,
update the go version to fix it.

Signed-off-by: Qi Wang [email protected]

Update go version from 1.16 to 1.17.
openshift/runtime-utils#15  CI failed since the go is out of date,
update the go version to fix it.

Signed-off-by: Qi Wang <[email protected]>
@openshift-ci openshift-ci bot requested review from adambkaplan and bparees April 5, 2022 19:41
@QiWang19
Copy link
Member Author

QiWang19 commented Apr 5, 2022

@adambkaplan Could you review and merge it?

@QiWang19
Copy link
Member Author

QiWang19 commented Apr 6, 2022

/assign @adambkaplan

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, QiWang19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022
@QiWang19
Copy link
Member Author

QiWang19 commented Apr 6, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 9f4da83 into openshift:master Apr 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

@QiWang19: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-runtime-utils-master.yaml using file ci-operator/config/openshift/runtime-utils/openshift-runtime-utils-master.yaml
  • ci-operator-4.11-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-runtime-utils-release-4.11.yaml using file ci-operator/config/openshift/runtime-utils/openshift-runtime-utils-release-4.11.yaml
  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-runtime-utils-release-4.12.yaml using file ci-operator/config/openshift/runtime-utils/openshift-runtime-utils-release-4.12.yaml
Details

In response to this:

Update go version from 1.16 to 1.17.
openshift/runtime-utils#15 CI failed since the go is out of date,
update the go version to fix it.

Signed-off-by: Qi Wang [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants