Skip to content

cluster-api-provider-openstack: main unit-test #27380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 1, 2022
Merged

cluster-api-provider-openstack: main unit-test #27380

openshift-merge-robot merged 1 commit into from
Apr 1, 2022

Conversation

@pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Mar 29, 2022 •
edited
Loading

Add a configuration file for the new 'main' branch of
cluster-api-provider-openstack, which is the actual downstream of the
kubernetes-sigs repository (as opposed to the 'master' branch, which
contains a fork of it).

The 'main' branch does not build into an image directly. Rather, it is
imported as a dependency into openshift/machine-api-provider-openstack.

With this commit, unit tests are required for merging PRs in the 'main'
branch of cluster-api-provider-openstack.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
@openshift-ci openshift-ci bot requested review from EmilienM and mdbooth March 29, 2022 15:05
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Mar 29, 2022

/hold
Image dance has to be fixed. Since we're not using the containerfile, we should probably use the most minimal, default base image for running go test ./....

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2022
@pierreprinetti pierreprinetti mentioned this pull request Mar 29, 2022
Merged
@pierreprinetti pierreprinetti force-pushed the upstream-capo branch 5 times, most recently from 6d802f0 to ebf07de Compare March 30, 2022 07:52
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Mar 30, 2022

/test pj-rehearse

@petr-muller
Copy link
Member

petr-muller commented Mar 30, 2022

oops, the #27380 (comment) was me

@pierreprinetti pierreprinetti force-pushed the upstream-capo branch 4 times, most recently from 3d6228d to 4477316 Compare April 1, 2022 08:01
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2022 •
edited
Loading

@pierreprinetti: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-api-provider-openstack/main/images d489f089ac783a9271d85dd8ea1fcbf28a6995ea link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti
cluster-api-provider-openstack: main unit-test
35e6312 
Add a configuration file for the new 'main' branch of
cluster-api-provider-openstack, which is the actual downstream of the
kubernetes-sigs repository (as opposed to the 'master' branch, which
contains a fork of it).

The 'main' branch does not build into an image directly. Rather, it is
imported as a dependency into openshift/machine-api-provider-openstack.

With this commit, unit tests are required for merging PRs in the 'main'
branch of cluster-api-provider-openstack.
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Apr 1, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2022
dulek
dulek reviewed Apr 1, 2022
View reviewed changes
...cluster-api-provider-openstack/openshift-cluster-api-provider-openstack-main-presubmits.yaml
always_run: true
branches:
- ^main$
- ^main-
Copy link
Contributor

@dulek dulek Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even plan to have main-<something> branches?

Copy link
Member Author

@pierreprinetti pierreprinetti Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remove that line, make jobs will add it back.

Copy link
Contributor

@dulek dulek Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, okay.

@dulek
Copy link
Contributor

dulek commented Apr 1, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 29f911a into openshift:master Apr 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2022

@pierreprinetti: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-api-provider-openstack-main.yaml using file ci-operator/config/openshift/cluster-api-provider-openstack/openshift-cluster-api-provider-openstack-main.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-api-provider-openstack-main-presubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-openstack/openshift-cluster-api-provider-openstack-main-presubmits.yaml
Details

In response to this:

Add a configuration file for the new 'main' branch of
cluster-api-provider-openstack, which is the actual downstream of the
kubernetes-sigs repository (as opposed to the 'master' branch, which
contains a fork of it).

The 'main' branch does not build into an image directly. Rather, it is
imported as a dependency into openshift/machine-api-provider-openstack.

With this commit, unit tests are required for merging PRs in the 'main'
branch of cluster-api-provider-openstack.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM EmilienM deleted the upstream-capo branch April 1, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@mdbooth mdbooth Awaiting requested review from mdbooth

1 more reviewer

@dulek dulek dulek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dulek dulek

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pierreprinetti @openshift-merge-robot @petr-muller @dulek