Skip to content

Conversation

@jluhrsen
Copy link
Contributor

Signed-off-by: Jamo Luhrsen [email protected]

@openshift-ci openshift-ci bot requested review from jkyros and sinnykumari February 22, 2022 17:43
@jluhrsen
Copy link
Contributor Author

/retest

1 similar comment
@jluhrsen
Copy link
Contributor Author

/retest

@jluhrsen
Copy link
Contributor Author

/assign @yuqi-zhang

the rehearsal failures are ok, as the jobs aren't necessarily very healthy anyway.

we were wanting this while working through a bz that we hoped would be fixed with a PR in MCO. We were having trouble
running jobs with cluster-bot and having an optional presubmit here would have helped. Although, this is now after the fact
(not going to use the MCO PR), it doesn't hurt to have this.

@deads2k
Copy link
Contributor

deads2k commented Feb 23, 2022

/approve

I'd like to have someone on the MCO team lgtm even an optional job on their repo if they're available.

Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me generally. I see that master/4.10 did both succeed 👍

Is ci/prow/config supposed to be failing?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jluhrsen, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2022

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/pj-rehearse a8e40b5 link false /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.11/e2e-azure-ovn-upgrade a8e40b5 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3db68a1 into openshift:master Feb 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2022

@jluhrsen: Updated the following 6 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-4.10-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.10.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.10.yaml
  • ci-operator-4.11-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.11.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.11.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
  • job-config-4.10 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.10-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.10-presubmits.yaml
  • job-config-4.11 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.11-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.11-presubmits.yaml
Details

In response to this:

Signed-off-by: Jamo Luhrsen [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jluhrsen
Copy link
Contributor Author

Is ci/prow/config supposed to be failing?

I can't find this failure? can you point me to it please? I wouldn't expect it to fail though.

@yuqi-zhang
Copy link
Contributor

I think it was maybe a flake, sorry, looks like everything is fine now

@jluhrsen jluhrsen deleted the bz-2040715 branch February 25, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants