Skip to content

Conversation

@crawford
Copy link
Contributor

The installer is soon going to require that the install config specifies
its version. This change won't have any effect in the meantime.

The installer is soon going to require that the install config specifies
its version. This change won't have any effect in the meantime.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2019
@wking
Copy link
Member

wking commented Jan 10, 2019

I went to double-check the location running a build from your PR, and I don't see the new field?

$ openshift-install version
openshift-install v0.9.0-master-10-g28a1d59cdb1531a6c9d3538b89d75b8c300953e6
$ openshift-install --dir ver create install-config
? SSH Public Key <none>
? Platform aws
? Region us-east-1
? Base Domain coreservices.team.coreos.systems
? Cluster Name wking
? Pull Secret [? for help] ***...***
$ grep apiVersion ver/install-config.yaml
# no hits?

@crawford
Copy link
Contributor Author

@wking I realized that last night. I still have to make a modification to the Installer PR to ensure that that field is populated.

@wking
Copy link
Member

wking commented Jan 10, 2019

/lgtm

We'll still need approval from the Ansible folks.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2019
@sdodson
Copy link
Member

sdodson commented Jan 10, 2019

/approve
for ansible job

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2019
@openshift-merge-robot openshift-merge-robot merged commit 8815948 into openshift:master Jan 10, 2019
@openshift-ci-robot
Copy link
Contributor

@crawford: Updated the following 3 configmaps:

  • prow-job-cluster-launch-installer-e2e configmap using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
  • prow-job-cluster-launch-installer-src configmap using the following files:
    • key cluster-launch-installer-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml
  • prow-job-cluster-launch-e2e-40 configmap using the following files:
    • key cluster-launch-e2e-40.yaml using file ci-operator/templates/openshift/openshift-ansible/cluster-launch-e2e-40.yaml
Details

In response to this:

The installer is soon going to require that the install config specifies
its version. This change won't have any effect in the meantime.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants