-
Notifications
You must be signed in to change notification settings - Fork 2.1k
ci-operator/step-registry/ipi/conf: Run ccoctl steps from cloud-credential-operator #25575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci-operator/step-registry/ipi/conf: Run ccoctl steps from cloud-credential-operator #25575
Conversation
…ntial-operator And, when necessary, use 'cli: latest' [1] to inject an 'oc' command from the release:latest image [2]. [1]: https://docs.ci.openshift.org/docs/architecture/step-registry/#injecting-the-oc-cli [2]: https://docs.ci.openshift.org/docs/architecture/ci-operator/#testing-with-an-existing-openshift-release
d40df4f to
c658c11
Compare
| from: cloud-credential-operator | ||
| cli: latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will have changes from the PR right? We want to test any changes to ccoctl as well. I am not sure if the current code does that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will still have new versions of both oc and ccoctl in the step, both as master stands before this PR, and as I have things set up in the PR. The PR just gets us there more conveniently, with less in-step hoop-jumping.
|
/uncc @petr-muller @bbguimaraes |
joelddiaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelddiaz, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@wking: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
And, when necessary, use
cli: latestto inject anoccommand from therelease:latestimage.