Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Jan 25, 2022

And, when necessary, use cli: latest to inject an oc command from the release:latest image.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2022
@wking wking force-pushed the ccoctl-from-latest branch from d40df4f to c658c11 Compare January 25, 2022 03:36
Comment on lines +3 to +4
from: cloud-credential-operator
cli: latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have changes from the PR right? We want to test any changes to ccoctl as well. I am not sure if the current code does that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will still have new versions of both oc and ccoctl in the step, both as master stands before this PR, and as I have things set up in the PR. The PR just gets us there more conveniently, with less in-step hoop-jumping.

@petr-muller
Copy link
Member

/uncc @petr-muller @bbguimaraes

Copy link
Contributor

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelddiaz, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/pj-rehearse c658c11 link false /test pj-rehearse
ci/rehearse/openshift/cloud-credential-operator/release-4.11/e2e-gcp-manual-oidc c658c11 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5ca9f25 into openshift:master Jan 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022

@wking: Updated the step-registry configmap in namespace ci at cluster app.ci using the following files:

  • key ipi-conf-aws-oidc-creds-deprovision-commands.sh using file ci-operator/step-registry/ipi/conf/aws/oidc-creds-deprovision/ipi-conf-aws-oidc-creds-deprovision-commands.sh
  • key ipi-conf-aws-oidc-creds-deprovision-ref.yaml using file ci-operator/step-registry/ipi/conf/aws/oidc-creds-deprovision/ipi-conf-aws-oidc-creds-deprovision-ref.yaml
  • key ipi-conf-aws-oidc-creds-provision-commands.sh using file ci-operator/step-registry/ipi/conf/aws/oidc-creds-provision/ipi-conf-aws-oidc-creds-provision-commands.sh
  • key ipi-conf-aws-oidc-creds-provision-ref.yaml using file ci-operator/step-registry/ipi/conf/aws/oidc-creds-provision/ipi-conf-aws-oidc-creds-provision-ref.yaml
  • key ipi-conf-gcp-oidc-creds-deprovision-commands.sh using file ci-operator/step-registry/ipi/conf/gcp/oidc-creds-deprovision/ipi-conf-gcp-oidc-creds-deprovision-commands.sh
  • key ipi-conf-gcp-oidc-creds-deprovision-ref.yaml using file ci-operator/step-registry/ipi/conf/gcp/oidc-creds-deprovision/ipi-conf-gcp-oidc-creds-deprovision-ref.yaml
  • key ipi-conf-gcp-oidc-creds-provision-commands.sh using file ci-operator/step-registry/ipi/conf/gcp/oidc-creds-provision/ipi-conf-gcp-oidc-creds-provision-commands.sh
  • key ipi-conf-gcp-oidc-creds-provision-ref.yaml using file ci-operator/step-registry/ipi/conf/gcp/oidc-creds-provision/ipi-conf-gcp-oidc-creds-provision-ref.yaml
Details

In response to this:

And, when necessary, use cli: latest to inject an oc command from the release:latest image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the ccoctl-from-latest branch January 25, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants