-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Gather apiserver latency metrics to be able to detect performance regression #25347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gather apiserver latency metrics to be able to detect performance regression #25347
Conversation
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
1f45565 to
51bb9f0
Compare
|
/approve |
|
/retest-required |
|
@dgrisonnet: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, dgrisonnet, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dgrisonnet: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Gather the 99th percentile and average of requests latency to be able to follow the trend of apiserver latency across all CI jobs. With this high-level information, we will be able to create better thresholds for openshift/origin#26739 which will allow us to prevent PR from being merged if they have an impact too important on the apiserver latency.
This additional information will also allow us to investigate whether openshift/kubernetes#1120 resolves this blocker bug https://bugzilla.redhat.com/show_bug.cgi?id=2039539.
/cc @deads2k @tkashem