Skip to content

Remove TEST_SKIPS_PROXY from metal-ipi tests#25271

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ardaguclu:remove-skips-proxy
Jan 14, 2022
Merged

Remove TEST_SKIPS_PROXY from metal-ipi tests#25271
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ardaguclu:remove-skips-proxy

Conversation

@ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented Jan 14, 2022

After the all backports merged, there is no need to use TEST_SKIPS_PROXY.
In addition to that, one of the tests' all backport paths also merged.

This PR removes TEST_SKIPS_PROXY and sig-instrumentation test from TEST_SKIPS section.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2022
@openshift-ci openshift-ci bot requested review from bbguimaraes and smg247 January 14, 2022 06:25
@ardaguclu
Copy link
Member Author

/assign @andfasano

@andfasano
Copy link
Contributor

@ardaguclu is there any dependency still not merged?

@ardaguclu
Copy link
Member Author

@ardaguclu is there any dependency still not merged?

These are the last 2 backports and they all merged;

openshift/origin#26344
openshift/origin#26733

@andfasano
Copy link
Contributor

Great thanks @ardaguclu

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, ardaguclu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2022

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.9-e2e-metal-ipi-serial-ipv4 dfe34e3 link unknown /test pj-rehearse
ci/rehearse/openshift/router/release-4.9/e2e-metal-ipi-ovn-router dfe34e3 link unknown /test pj-rehearse
ci/prow/pj-rehearse dfe34e3 link false /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.9-e2e-metal-ipi-virtualmedia dfe34e3 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.10-e2e-metal-ipi-upgrade-ovn-ipv6 dfe34e3 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.10-e2e-metal-ipi-serial-ovn-ipv6 dfe34e3 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.10-e2e-metal-ipi-serial-compact dfe34e3 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 607df8e into openshift:master Jan 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2022

@ardaguclu: Updated the step-registry configmap in namespace ci at cluster app.ci using the following files:

  • key baremetalds-e2e-test-commands.sh using file ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-commands.sh
  • key baremetalds-e2e-test-ref.yaml using file ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-ref.yaml
Details

In response to this:

After the all backports merged, there is no need to use TEST_SKIPS_PROXY.
In addition to that, one of the tests' all backport paths also merged.

This PR removes TEST_SKIPS_PROXY and sig-instrumentation test from TEST_SKIPS section.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants