Skip to content

Conversation

@nirarg
Copy link
Contributor

@nirarg nirarg commented Dec 14, 2021

This is done by running "make new-repo"
Adding the following repository: https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt

@nirarg nirarg changed the title Add new repository - openshift/cluster-api-provider-kubevirt [WIP] Add new repository - openshift/cluster-api-provider-kubevirt Dec 14, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2021
@nirarg nirarg force-pushed the cluster-api-provider-kubevirt branch 5 times, most recently from 41f0023 to 6bc973e Compare December 14, 2021 12:26
Comment on lines 259 to 279
cluster_groups:
build_farm_ci:
clusters:
- app.ci
- build01
- build02
- build03
- build04
- vsphere
namespaces:
- ci
build_farm_ocp:
clusters:
- app.ci
- build01
- build02
- build03
- build04
- vsphere
namespaces:
- ocp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes in this _plugins.yaml file look a bit suspicious considering we're just trying to enable ci on the openshift/cluster-api-provider-kubevirt repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, also noticed to this change, created by the auto generator (make new-repo)
I removed this change

Comment on lines 19 to 22
- as: func-tests
commands: go mod tidy && go mod vendor && make functest
container:
from: bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we'll be successful in running the functional tests like this. For now i think we can just execute the unit tests until we get a func test suite that can execute on openshift ci.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree
I removed the func tests, The func tests will be added later

@nirarg nirarg force-pushed the cluster-api-provider-kubevirt branch from 6bc973e to 516d8e8 Compare December 15, 2021 04:01
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021
@nirarg nirarg changed the title [WIP] Add new repository - openshift/cluster-api-provider-kubevirt Add new repository - openshift/cluster-api-provider-kubevirt Dec 15, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2021
@nunnatsa
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirarg, nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

@nirarg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-api-provider-kubevirt/main/func-tests 6bc973e link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 42893b4 into openshift:master Dec 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

@nirarg: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-api-provider-kubevirt-main.yaml using file ci-operator/config/openshift/cluster-api-provider-kubevirt/openshift-cluster-api-provider-kubevirt-main.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-api-provider-kubevirt-main-presubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-kubevirt/openshift-cluster-api-provider-kubevirt-main-presubmits.yaml
  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-cluster-api-provider-kubevirt-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-api-provider-kubevirt/_pluginconfig.yaml
Details

In response to this:

This is done by running "make new-repo"
Adding the following repository: https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nirarg nirarg deleted the cluster-api-provider-kubevirt branch March 24, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants