Skip to content

Add CI jobs for CAPI providers #24534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Feb 7, 2022
Merged

Add CI jobs for CAPI providers #24534

openshift-merge-robot merged 2 commits into from
Feb 7, 2022

Conversation

@alexander-demicev
Copy link
Contributor

@alexander-demicev alexander-demicev commented Dec 13, 2021 •
edited
Loading

Add CI jobs for CAPI providers, these components are a part of Cluster API integration and are described here openshift/enhancements#913.
All Machine API related code has been moved to https://github.com/openshift/machine-api-provider-azure, https://github.com/openshift/machine-api-provider-gcp, https://github.com/openshift/machine-api-provider-aws repos, this means that it's safe to use cluster-api-provider-* repos for the upstream providers https://github.com/kubernetes-sigs/cluster-api-provider-*.

@openshift-ci openshift-ci bot requested review from JoelSpeed and elmiko December 13, 2021 14:02
@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 28, 2021
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2022
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Feb 2, 2022

I see there are some images with image vendoring, can we fix those so that the tests pass or would you rather have the tests merged first?

They look ok and as if they are working as far as I can tell

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2022
@alexander-demicev alexander-demicev changed the title Add upstream CAPZ CI jobs and image Add CI jobs for CAPI providers Feb 2, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2022
@alexander-demicev
Copy link
Contributor Author

alexander-demicev commented Feb 3, 2022

/retest

1 similar comment
@alexander-demicev
Copy link
Contributor Author

alexander-demicev commented Feb 3, 2022

/retest

@alexander-demicev
Copy link
Contributor Author

alexander-demicev commented Feb 3, 2022

/retest

bparees
bparees reviewed Feb 3, 2022
View reviewed changes
core-services/image-mirroring/openshift/mapping_origin_4_11 Outdated
Copy link
Contributor

@bparees bparees Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://github.com/openshift/release/blob/master/core-services/image-mirroring/openshift/GUIDELINES.md

admittedly there are two conflicting guidelines there, in this case, but i think we want the platform prefix to come first, so gcp-capi-controllers (i don't think we need "cluster" in the name) and similar for the other ones.

@smarterclayton agree?

Copy link
Contributor

@smarterclayton smarterclayton Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, <platform>-<clear_name_describing_function>-<type_of_image>.

I don't think CAPI is sufficient on its own, i would probably say gcp-cluster-api-controllers is the pattern I'd expect

Copy link
Contributor Author

@alexander-demicev alexander-demicev Feb 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, all fixed. My intention was to have all CAPI related images near each other in the list.

Copy link
Contributor

@smarterclayton smarterclayton Feb 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, we tilted this way because ultimately we want to be clear about what components are required on a given cluster, and like other cloud provider resources there can be only one active at a time.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2022

@alexander-demichev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/build-farm/hive-dry 020dae029b163e8cdc646b2cace56ea1f1658227 link true /test hive-dry
ci/build-farm/app-ci-config-dry 020dae029b163e8cdc646b2cace56ea1f1658227 link true /test app-ci-config-dry
ci/build-farm/build04-dry 020dae029b163e8cdc646b2cace56ea1f1658227 link true /test build04-dry
ci/build-farm/build01-dry 020dae029b163e8cdc646b2cace56ea1f1658227 link true /test build01-dry
ci/build-farm/build03-dry 020dae029b163e8cdc646b2cace56ea1f1658227 link true /test build03-dry
ci/prow/boskos-config 020dae029b163e8cdc646b2cace56ea1f1658227 link true /test boskos-config
ci/prow/ci-secret-bootstrap-config-validation 020dae029b163e8cdc646b2cace56ea1f1658227 link true /test ci-secret-bootstrap-config-validation
ci/prow/boskos-config-generation 020dae029b163e8cdc646b2cace56ea1f1658227 link true /test boskos-config-generation
ci/rehearse/openshift/cluster-api-provider-aws/master/unit 1a1badb link unknown /test pj-rehearse
ci/prow/pj-rehearse 1a1badb link false /test pj-rehearse
ci/rehearse/openshift/cluster-api-provider-azure/master/e2e-azure-serial 1a1badb link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-api-provider-aws/master/e2e-aws-serial 1a1badb link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-api-provider-gcp/master/unit 1a1badb link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 4, 2022

I'll let ben approve.

@bparees
Copy link
Contributor

bparees commented Feb 4, 2022

/approve

thanks for fixing up the names

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2022
Fedosin
Fedosin approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev, bparees, Fedosin, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5ce887b into openshift:master Feb 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2022

@alexander-demichev: Updated the following 4 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-api-provider-aws-master.yaml using file ci-operator/config/openshift/cluster-api-provider-aws/openshift-cluster-api-provider-aws-master.yaml
    • key openshift-cluster-api-provider-azure-master.yaml using file ci-operator/config/openshift/cluster-api-provider-azure/openshift-cluster-api-provider-azure-master.yaml
    • key openshift-cluster-api-provider-gcp-master.yaml using file ci-operator/config/openshift/cluster-api-provider-gcp/openshift-cluster-api-provider-gcp-master.yaml
  • job-config-master-postsubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-api-provider-aws-master-postsubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-aws/openshift-cluster-api-provider-aws-master-postsubmits.yaml
    • key openshift-cluster-api-provider-azure-master-postsubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-azure/openshift-cluster-api-provider-azure-master-postsubmits.yaml
    • key openshift-cluster-api-provider-gcp-master-postsubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-gcp/openshift-cluster-api-provider-gcp-master-postsubmits.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-api-provider-aws-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-aws/openshift-cluster-api-provider-aws-master-presubmits.yaml
    • key openshift-cluster-api-provider-azure-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-azure/openshift-cluster-api-provider-azure-master-presubmits.yaml
    • key openshift-cluster-api-provider-gcp-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-gcp/openshift-cluster-api-provider-gcp-master-presubmits.yaml
  • image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:
    • key mapping_origin_4_11 using file core-services/image-mirroring/openshift/mapping_origin_4_11
Details

In response to this:

Add CI jobs for CAPI providers, these components are a part of Cluster API integration and are described here openshift/enhancements#913.
All Machine API related code has been moved to https://github.com/openshift/machine-api-provider-azure, https://github.com/openshift/machine-api-provider-gcp, https://github.com/openshift/machine-api-provider-aws repos, this means that it's safe to use cluster-api-provider-* repos for the upstream providers https://github.com/kubernetes-sigs/cluster-api-provider-*.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees bparees left review comments

@elmiko elmiko Awaiting requested review from elmiko

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

+2 more reviewers

@smarterclayton smarterclayton smarterclayton left review comments

@Fedosin Fedosin Fedosin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JoelSpeed JoelSpeed

@Fedosin Fedosin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alexander-demicev @JoelSpeed @smarterclayton @bparees @Fedosin @openshift-merge-robot