Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding kn-plugin-event sender image to OpenShift CI #24476

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Adding kn-plugin-event sender image to OpenShift CI #24476

merged 3 commits into from
Dec 13, 2021

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Dec 10, 2021 •
edited
Loading

  • Adding kn-plugin-event sender image to OpenShift CI
  • Publishing image to be used in integration testing

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2021
@cardil cardil force-pushed the feature/kn-event-sender-image branch from 0a66975 to 9a424cc Compare December 10, 2021 14:35
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2021
@cardil cardil force-pushed the feature/kn-event-sender-image branch from 9a424cc to 94ab62b Compare December 10, 2021 14:53
@cardil cardil force-pushed the feature/kn-event-sender-image branch from 94ab62b to f219580 Compare December 10, 2021 15:24
@cardil cardil changed the title Adding kn-plugin-event to OpenShift CI Adding kn-plugin-event sender image to OpenShift CI Dec 10, 2021
@cardil
Copy link
Contributor Author

cardil commented Dec 10, 2021

/test pj-rehearse

@cardil
Copy link
Contributor Author

cardil commented Dec 13, 2021

/cc @mgencur

@openshift-ci openshift-ci bot requested a review from mgencur December 13, 2021 14:13
@mgencur
Copy link
Contributor

mgencur commented Dec 13, 2021

/lgtm

@cardil cardil mentioned this pull request Dec 13, 2021
Merged
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2021

@cardil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b398bfd into openshift:master Dec 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2021

@cardil: Updated the following 2 configmaps:

  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-knative-kn-plugin-event-release-0.26.yaml using file ci-operator/config/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-0.26.yaml
    • key openshift-knative-kn-plugin-event-release-1.0.yaml using file ci-operator/config/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.0.yaml
    • key openshift-knative-kn-plugin-event-release-next.yaml using file ci-operator/config/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-next.yaml
  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-knative-kn-plugin-event-release-0.26-postsubmits.yaml using file ci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-0.26-postsubmits.yaml
    • key openshift-knative-kn-plugin-event-release-0.26-presubmits.yaml using file ci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-0.26-presubmits.yaml
    • key openshift-knative-kn-plugin-event-release-1.0-postsubmits.yaml using file ci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.0-postsubmits.yaml
    • key openshift-knative-kn-plugin-event-release-1.0-presubmits.yaml using file ci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-1.0-presubmits.yaml
    • key openshift-knative-kn-plugin-event-release-next-postsubmits.yaml using file ci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-next-postsubmits.yaml
    • key openshift-knative-kn-plugin-event-release-next-presubmits.yaml using file ci-operator/jobs/openshift-knative/kn-plugin-event/openshift-knative-kn-plugin-event-release-next-presubmits.yaml

In response to this:

  • Adding kn-plugin-event sender image to OpenShift CI
  • Publishing image to be used in integration testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cardil cardil deleted the feature/kn-event-sender-image branch December 13, 2021 15:15
cardil added a commit to cardil/knative-client that referenced this pull request Dec 14, 2021
@cardil
[0.26] Use sender image promoted by OpenShift CI
e29326d 
Align the default sender image to one promoted by OpenShift CI.

This aligns defaults with openshift-knative/serverless-operator#1337

Further refs.:

 - openshift/release#24476
 - openshift/release#24549
@cardil cardil mentioned this pull request Dec 14, 2021
Merged
openshift-merge-robot pushed a commit to openshift/knative-client that referenced this pull request Dec 14, 2021
@cardil
[0.26] Use sender image promoted by OpenShift CI (#910)
cf0c36e 
Align the default sender image to one promoted by OpenShift CI.

This aligns defaults with openshift-knative/serverless-operator#1337

Further refs.:

 - openshift/release#24476
 - openshift/release#24549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejvasek matejvasek Awaiting requested review from matejvasek

@zroubalik zroubalik Awaiting requested review from zroubalik

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@mgencur mgencur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cardil @mgencur @openshift-merge-robot