use oc config set/use-context with kubeadmin login check in cluster-launch-installer templates #2440
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sallyom If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
size/S
sallyom
changed the title
There was a problem hiding this comment.
be consistent in use of ${ ... }
There was a problem hiding this comment.
I don't see what value failing has here?
There was a problem hiding this comment.
All the other steps are "waits", not fails
There was a problem hiding this comment.
done, made it an until..; do \ sleep 10
sallyom
force-pushed
the
add-kubeadmin-login-to-installer-templates
branch
2 times, most recently
from
b0cadaf to
9d1cc69
Compare
sallyom
force-pushed
the
add-kubeadmin-login-to-installer-templates
branch
from
9d1cc69 to
94ba816
Compare
…staller templates
sallyom
force-pushed
the
add-kubeadmin-login-to-installer-templates
branch
from
94ba816 to
90f98d3
Compare
| done | ||
| # oh god the blood | ||
| sleep 180 | ||
| # can remove this check once a proper test is added to origin e2e |
There was a problem hiding this comment.
Why not write the e2e test?
There was a problem hiding this comment.
I'm doing that now. This ensures no breaking changes are merged b4 that test is in place (auth team is refactoring, configuring oauth, etc now). However, with how long this has taken to merge, might-as-well wait for the e2e, as i'm finally able to get to it now.
There was a problem hiding this comment.
This is, however, a good indicator that a cluster is healthy, ready to execute the e2e suite. Configuring the kubeadmin user requires a patch, takes a few minutes for the cluster to recover from that. Might want to keep this check in, but I'll close if not, since I'll have the e2e test done soonish.
There was a problem hiding this comment.
Why doesn't the installer handle those before handing off the cluster as "ready" ?
There was a problem hiding this comment.
I am just very suspicious of any bash in here ..
There was a problem hiding this comment.
Yeah, this feels like something that should be part of the installer, not post installer. Or if it shouldn't, we should have a good reason not to (like we don't want the password in the clear, but the private key is in the clear, so it's kind of a wash).
There was a problem hiding this comment.
@wking I don't see how this could be part of the installer?
a) Installer would run oc login and that would require oc be available?
or
b) Installer would have to vendor origin code to run the equivalent of oc login?
maybe I'm missing something, clue me in please if so.
I've opened a PR to add a smoke-4 test for kubeadmin login, instead: openshift/origin#21733
|
closing this in favor of openshift/origin#21733 |
4 participants
This PR adds a check for kubeadmin user login. This check is a good indication that all is well in a cluster after the kubeadmin user is patched in (KubeAPIServerOperatorConfig).
@smarterclayton