Skip to content

Change hypershift build root to repo #23911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 23, 2021
Merged

Change hypershift build root to repo #23911

openshift-merge-robot merged 1 commit into from
Nov 23, 2021

Conversation

@enxebre
Copy link
Member

@enxebre enxebre commented Nov 23, 2021

This along with openshift/hypershift#703 and #23848 let us bump golang versions by making changes to the source repo only.

@enxebre
Copy link
Member Author

enxebre commented Nov 23, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2021
@openshift-ci openshift-ci bot requested review from csrwng and ironcladlou November 23, 2021 15:51
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2021
@enxebre
Change hypershift build root to repo
1e6125a 
This along with openshift/hypershift#703 and openshift#23848 let us bump golang versions by making changes to the source repo only.
@enxebre enxebre force-pushed the hypershift-build-root branch from 27205a7 to 1e6125a Compare November 23, 2021 16:07
@enxebre
Copy link
Member Author

enxebre commented Nov 23, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2021 •
edited
Loading

@enxebre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/hypershift/main/e2e-aws 27205a702b9f65bcd13b8ee84c13edb60b52b76b link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-hypershift-main-e2e-aws-periodic 27205a702b9f65bcd13b8ee84c13edb60b52b76b link unknown /test pj-rehearse
ci/rehearse/openshift/hypershift/main/e2e-aws-metrics 27205a702b9f65bcd13b8ee84c13edb60b52b76b link unknown /test pj-rehearse
ci/prow/pj-rehearse 27205a702b9f65bcd13b8ee84c13edb60b52b76b link false /test pj-rehearse
ci/rehearse/periodic-ci-openshift-hypershift-main-e2e-aws-pooled-periodic-conformance-serial 1e6125a link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-hypershift-main-e2e-aws-pooled-periodic-conformance 1e6125a link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alvaroaleman
Copy link
Contributor

alvaroaleman commented Nov 23, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit ad2dbf6 into openshift:master Nov 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2021

@enxebre: Updated the following 4 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-hypershift-main.yaml using file ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
  • job-config-master-periodics configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-hypershift-main-periodics.yaml using file ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-periodics.yaml
  • job-config-master-postsubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-hypershift-main-postsubmits.yaml using file ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-postsubmits.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-hypershift-main-presubmits.yaml using file ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yaml
Details

In response to this:

This along with openshift/hypershift#703 and #23848 let us bump golang versions by making changes to the source repo only.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

1 more reviewer

@alvaroaleman alvaroaleman alvaroaleman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alvaroaleman alvaroaleman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@enxebre @alvaroaleman @openshift-merge-robot