Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Nov 8, 2021

And also for the associated ci-operator/jobs/... directory. We've been reviewers since a513fb4 (#17805), and being approvers will allow Vadim and I to collaborate on things like chained update timeout bumps without having to track down a free member of the technical release team (since they're usually off fighting fires on more central jobs).

…s approvers

And also for the associated ci-operator/jobs/... directory.  We've
been reviewers since a513fb4 (release: make TRT + usual suspects
owners, 2021-04-16, openshift#17805), and being approvers will allow Vadim and
I to collaborate on things like chained update timeout bumps [1]
without having to track down a free member of the technical release
team (since they're usually off fighting fires on more central jobs).

[1]: openshift#21355 (comment)
@dgoodwin
Copy link
Contributor

dgoodwin commented Nov 8, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2021
@openshift-ci openshift-ci bot requested review from deads2k and vrutkovs November 8, 2021 18:30
@openshift-merge-robot openshift-merge-robot merged commit 211c31b into openshift:master Nov 8, 2021
@wking wking deleted the vrutkovs-wking-release-informer-approvers branch November 8, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants