openshift-e2e-test: Allow if no TEST_SKIPS match#22755
openshift-e2e-test: Allow if no TEST_SKIPS match#22755ardaguclu wants to merge 1 commit intoopenshift:masterfrom
Conversation
This PR prints warning message when tests not found in TEST_SKIPS and allows CI steps continue. There is a high probability that tests are not in TEST_SKIPS especially for different TEST_SUITES(i.e. openshift/conformance/serial) and this does not an indication of a failure. Instead failing with an error message, process continues with an warning message.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ardaguclu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@ardaguclu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Is there any example of that? Erroring on invalid TEST_SKIPS helps us keep it updated |
|
Thanks @vrutkovs. After further investigation, you are right. Indeed it is useful for showing possible errors. I thought that all workflows use same TEST_SKIPS section, however it seems that they might use their own TEST_SKIPS by overriding the default one. Thus, in favor of this, I'm closing this PR. /close |
|
@ardaguclu: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR prints warning message when tests not found in TEST_SKIPS and
allows CI steps continue.
There is a high probability that tests are not in TEST_SKIPS especially
for different TEST_SUITES(i.e. openshift/conformance/serial) and this
does not an indication of a failure.
Instead failing with an error message, process continues with an
warning message.