Set KUBE_SSH_USER for new installer for AWS tests #2274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows certain tests to check node conditions. Also add a new e2e-aws-all release job that will run the full suite for testing as we get back to full coverage.
openshift-ci-robot
added
the
size/M
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
@smarterclayton: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Apr 24, 2019
These are from b7cc916 (Set KUBE_SSH_USER for new installer for AWS tests, openshift#2274) and 43dde9e (Set KUBE_SSH_BASTION and KUBE_SSH_KEY_PATH in installer tests, 2018-12-23, openshift#2469). But moving forward, reliable SSH access direct to nodes will be hard, with things like openshift/installer@6add0ab447 (Remove public IPs from masters, 2019-01-10, openshift/installer#1045) making a SSH bastion a requirement for that sort of thing (at least on AWS). Going forward, ideally e2e tests can be ported to use privileged pods within the cluster to check what they need to check. But however that works out, stop carrying local dead code that is not affecting test results. We can always drag it back out of version control later if it turns out we actually want to go down the KUBE_SSH_* route.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows certain tests to check node conditions. Also add a new e2e-aws-all release
job that will run the full suite for testing as we get back to full coverage.