-
Notifications
You must be signed in to change notification settings - Fork 2.1k
ci-operator/step-registry/openshift/e2e/test: Best-effort ack-4.8-kube-1.22-api-removals-in-4.9 #22368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci-operator/step-registry/openshift/e2e/test: Best-effort ack-4.8-kube-1.22-api-removals-in-4.9 #22368
Conversation
…e-1.22-api-removals-in-4.9
Avoid [1]:
alert ClusterNotUpgradeable fired for 1115 seconds with labels: {condition="Upgradeable", endpoint="metrics", name="version", severity="warning"}
for tests that install 4.8 and then sit on it for over an hour, now
that [2] has landed in 4.8. [3] will follow up with code to handle CI
that installs an earlier release and updates into 4.8 or later.
[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.8-e2e-aws-serial/1443018123379740672
[2]: openshift/cluster-version-operator#647
[3]: openshift/origin#26446
ci-operator/step-registry/openshift/e2e/test/openshift-e2e-test-commands.sh
Show resolved
Hide resolved
|
Two jobs exercising both sides of this code: a 4.7 install and a 4.9 install. We'll see what they have to say about the patch and gathered ack-state when they complete. Until then: /hold |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
4.7 job is happy, and: $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/22368/rehearse-22368-pull-ci-operator-framework-operator-lifecycle-manager-release-4.7-e2e-gcp/1443318799435567104/artifacts/e2e-gcp/openshift-e2e-test/build-log.txt | grep -A1 admin-acks
Error from server (NotFound): configmaps "admin-acks" not found
failed to ack the 4.9 Kube v1beta1 removals; possibly API-server issue, or a pre-4.8 release imageis what we'd expect for 4.7. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
4.9 job failed on $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/22368/rehearse-22368-pull-ci-openshift-router-release-4.9-e2e-agnostic/1443318801436250112/artifacts/e2e-agnostic/openshift-e2e-test/build-log.txt | grep admin-acks
configmap/admin-acks patchedAck is in place: $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/22368/rehearse-22368-pull-ci-openshift-router-release-4.9-e2e-agnostic/1443318801436250112/artifacts/e2e-agnostic/gather-extra/artifacts/configmaps.json | jq '.items[] | select(.metadata.name == "admin-acks").data'
{
"ack-4.8-kube-1.22-api-removals-in-4.9": "true"
}And ClusterVersion conditions are expected (notably no $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/22368/rehearse-22368-pull-ci-openshift-router-release-4.9-e2e-agnostic/1443318801436250112/artifacts/e2e-agnostic/gather-extra/artifacts/clusterversion.json | jq -r '.items[].status.conditions[] | .lastTransitionTime + " " + .ty
pe + "=" + .status + " " + (.reason // "-") + ": " + (.message // "-")'
2021-09-29T21:24:05Z RetrievedUpdates=False NoChannel: The update channel has not been configured.
2021-09-29T21:48:58Z Available=True -: Done applying 4.9.0-0.ci.test-2021-09-29-210457-ci-op-24bshkpi-latest
2021-09-29T21:48:58Z Failing=False -: -
2021-09-29T21:48:58Z Progressing=False -: Cluster version is 4.9.0-0.ci.test-2021-09-29-210457-ci-op-24bshkpi-latest/hold cancel |
|
@wking: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Avoid:
for tests that install 4.8 and then sit on it for over an hour, now that openshift/cluster-version-operator#647 has landed in 4.8. openshift/origin#26446 will follow up with code to handle CI that installs an earlier release and updates into 4.8 or later.