Skip to content

Add Azure CSI driver test on Azure Stack #22062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Sep 24, 2021
Merged

Add Azure CSI driver test on Azure Stack #22062

openshift-merge-robot merged 2 commits into from
Sep 24, 2021

Conversation

@jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Sep 20, 2021 •
edited
Loading

Based on #18796, adding pre-submit test for the CSI driver on ASH.
I will turn it into a periodic job in a separate PR.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2021
@bertinatto
Copy link
Member

bertinatto commented Sep 21, 2021

/test pj-rehearse

@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 21, 2021

@bertinatto I don't think the test is going to pass

@bertinatto
Copy link
Member

bertinatto commented Sep 21, 2021 

{"component":"entrypoint","file":"prow/entrypoint/run.go:255","func":"k8s.io/test-infra/prow/entrypoint.gracefullyTerminate","level":"error","msg":"Process did not exit before 10m0s grace period","severity":"error","time":"2021-09-21T16:51:24Z"}
{"component":"entrypoint","error":"os: process already finished","file":"prow/entrypoint/run.go:257","func":"k8s.io/test-infra/prow/entrypoint.gracefullyTerminate","level":"error","msg":"Could not kill process after grace period","severity":"error","time":"2021-09-21T16:51:24Z"}
{"component":"entrypoint","error":"process timed out","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2021-09-21T16:51:24Z"}
error: failed to execute wrapped command: exit status 127

I'm not sure if this is a flake or not, so I'm re-scheduling the job:

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 22, 2021

The test was killed after 2 hours. Increasing parallelism...

@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 22, 2021

/retest

1 similar comment
@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 22, 2021

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 22, 2021

With 4 tests in parallel, the tests succeeded after 1h28m0s. That's feels like too much (regular Azure with 20 tests in parallel finishes in 17m). Trying 8 tests in parallel, expecting 45 minutes.

@jsafrane
Run the ASH tests with less parallel tests
50cac90 
Out ASH env. is very slow. "4" usually passes under 2 hours. With "8", some
random tests start timing out.
@jsafrane jsafrane changed the title WIP: Add Azure CSI driver test on Azure Stack Add Azure CSI driver test on Azure Stack Sep 23, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2021
@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 23, 2021

"8" failed. Going back to 4 and removing WIP.

@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 23, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2021 •
edited
Loading

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/operator-framework/operator-lifecycle-manager/release-4.7/e2e-upgrade e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/release-4.9/e2e-azure-ovn-dualstack e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/openshift/kubernetes/release-4.9/k8s-e2e-gcp e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/openshift/kubernetes/release-4.9/k8s-e2e-gcp-serial e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/openshift/sandboxed-containers-operator/master/sandboxed-containers-operator-e2e e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-aws-techpreview e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-aws-upgrade-single-node e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/openshift/openstack-cinder-csi-driver-operator/release-4.9/e2e-openstack-csi e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-aws-calico e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-cluster-api-provider-kubevirt-release-4.9-sanity-ovn e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/openshift/builder/release-4.9/e2e-aws-cgroupsv2 e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-azure-techpreview e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/openshift/kubernetes/release-4.9/e2e-openstack-csi-manila e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/openshift/router/release-4.9/e2e-agnostic e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-azure-ovn e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-azure-cilium e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-azurestack e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-aws-techpreview-serial e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-azure-serial e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-azurestack-upi e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.7-upgrade-from-stable-4.6-e2e-ovirt-upgrade e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.6-upgrade-from-stable-4.5-e2e-ovirt-upgrade e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/openshift/router/release-4.9/e2e-upgrade e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-etcd-operator/release-4.9/e2e-gcp-disruptive-ovn e0043d501632dda5809a589d97f26db3e8453e9b link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 23, 2021

/retest

bertinatto
bertinatto reviewed Sep 24, 2021
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2021
@patrickdillon
Copy link
Contributor

patrickdillon commented Sep 24, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit 5c2fcde into openshift:master Sep 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2021

@jsafrane: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-azure-disk-csi-driver-operator-master.yaml using file ci-operator/config/openshift/azure-disk-csi-driver-operator/openshift-azure-disk-csi-driver-operator-master.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-azure-disk-csi-driver-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/azure-disk-csi-driver-operator/openshift-azure-disk-csi-driver-operator-master-presubmits.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/azurestack/upi-csi/OWNERS
    • key openshift-e2e-azurestack-upi-csi-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/azurestack/upi-csi/openshift-e2e-azurestack-upi-csi-workflow.metadata.json
    • key openshift-e2e-azurestack-upi-csi-workflow.yaml using file ci-operator/step-registry/openshift/e2e/azurestack/upi-csi/openshift-e2e-azurestack-upi-csi-workflow.yaml
Details

In response to this:

Based on #18796, adding pre-submit test for the CSI driver on ASH.
I will turn it into a periodic job in a separate PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@e-tienne e-tienne Awaiting requested review from e-tienne

1 more reviewer

@bertinatto bertinatto bertinatto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bertinatto bertinatto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jsafrane @bertinatto @patrickdillon @openshift-merge-robot