Skip to content

Conversation

@droslean
Copy link
Member

@droslean droslean commented Sep 7, 2021

/cc @openshift/test-platform

Signed-off-by: Nikolaos Moraitis [email protected]

@openshift-ci openshift-ci bot requested a review from a team September 7, 2021 10:08
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2021
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add it to the reaper: #21542

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How were these numbers computed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the same with azure4.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which may not be correct. How do we know we have enough quota in the second account?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a similar spreadsheet like we used for AWS2 and GCP2? If yes, have you checked the quotas? If no, can we get one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2nd subscription has exactly the same quotas as the 1st one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me correct me here. The 2nd subscription with specific quotas have been requested in https://issues.redhat.com/browse/DPP-7124. Let me /hold this and ask James for the speadsheet so we can calculate the boskos leases with an exact number.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wking How can we calculate this like you did in #12840 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit/PR message in #12840 has the method I used previously. Is there a particular step that wasn't clear?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so we are

  • Central US:

    • 1200 standardDSv3Family / 40 = 30 clusters
    • 600 LowPriorityCores / 18 vCPUs per spot test = 33 clusters
    • 100 Public IPs / 3 = 33 clusters
  • eastus/eastus2/westus

    • 350 / 40 = 8 clusters
    • 350 LowPriorityCores / 18 = 19 clusters
    • 100 Public IPs / 3 = 33 clusters

So we are good to merge :)

@droslean
Copy link
Member Author

droslean commented Sep 7, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2021
@droslean
Copy link
Member Author

droslean commented Sep 8, 2021

@wking Can you take a look on this?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@droslean
Copy link
Member Author

droslean commented Sep 9, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7ccd206 into openshift:master Sep 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

@droslean: Updated the resources configmap in namespace ci at cluster app.ci using the following files:

  • key boskos.yaml using file core-services/prow/02_config/_boskos.yaml
Details

In response to this:

/cc @openshift/test-platform

Signed-off-by: Nikolaos Moraitis [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@droslean droslean deleted the azure-2-boskos branch September 9, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants