-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add boskos leases for the 2nd azure subscription #21633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boskos leases for the 2nd azure subscription #21633
Conversation
petr-muller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to add it to the reaper: #21542
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How were these numbers computed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the same with azure4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which may not be correct. How do we know we have enough quota in the second account?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a similar spreadsheet like we used for AWS2 and GCP2? If yes, have you checked the quotas? If no, can we get one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2nd subscription has exactly the same quotas as the 1st one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me correct me here. The 2nd subscription with specific quotas have been requested in https://issues.redhat.com/browse/DPP-7124. Let me /hold this and ask James for the speadsheet so we can calculate the boskos leases with an exact number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit/PR message in #12840 has the method I used previously. Is there a particular step that wasn't clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so we are
-
Central US:
- 1200 standardDSv3Family / 40 = 30 clusters
- 600 LowPriorityCores / 18 vCPUs per spot test = 33 clusters
- 100 Public IPs / 3 = 33 clusters
-
eastus/eastus2/westus
- 350 / 40 = 8 clusters
- 350 LowPriorityCores / 18 = 19 clusters
- 100 Public IPs / 3 = 33 clusters
So we are good to merge :)
Signed-off-by: Nikolaos Moraitis <[email protected]>
85b7c02 to
8c1fe5a
Compare
|
/hold |
|
@wking Can you take a look on this? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droslean, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
@droslean: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @openshift/test-platform
Signed-off-by: Nikolaos Moraitis [email protected]