Skip to content

revert preserving bootstrap node on SNO ipi builds #21088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 24, 2021
Merged

revert preserving bootstrap node on SNO ipi builds #21088

openshift-merge-robot merged 1 commit into from
Aug 24, 2021

Conversation

@osherdp
Copy link
Contributor

@osherdp osherdp commented Aug 12, 2021

Reverts #20592
/cc @deads2k @eranco74
/hold

I do think we didn't yet got the chance to use the artifacts (the bug is reproducing once a week or two), but let's have the revert ready for now and start thinking about our options.

@openshift-ci openshift-ci bot requested review from deads2k and eranco74 August 12, 2021 13:13
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2021
@deads2k
Copy link
Contributor

deads2k commented Aug 12, 2021

/lgtm
/approve
/hold

holding until 8/19. On 8/19, it is time to revert the change. If it's been more than two weeks, it's highly suggestive that we need a product change to enable debugging in the field.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 12, 2021
@eranco74
Copy link
Contributor

eranco74 commented Aug 16, 2021

The issue didn't reproduce since the preserved bootstrap PR merged.

@deads2k
Copy link
Contributor

deads2k commented Aug 23, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 24, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@osherdp osherdp force-pushed the revert/preserving-bootstrap-on-sno branch from 5a0bb21 to 9bc6ab4 Compare August 24, 2021 06:28
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2021
@osherdp osherdp force-pushed the revert/preserving-bootstrap-on-sno branch from 9bc6ab4 to f510267 Compare August 24, 2021 06:42
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2021

@osherdp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/router/release-4.9/e2e-agnostic 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/origin/release-4.1/e2e-aws-image-ecosystem 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/origin/release-4.1/e2e-aws-builds 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/builder/release-4.9/e2e-aws-cgroupsv2 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/origin/release-4.9/e2e-aws 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/origin/release-4.2/e2e-cmd 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.9/e2e-aws-techpreview-featuregate 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.9/e2e-gcp-single-node 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/cloud-credential-operator/release-4.9/e2e-aws-manual-oidc 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/origin/release-4.6/e2e-agnostic-cmd 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.5/e2e-ovirt 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/okd-machine-os/release-4.7/e2e-ovirt 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/origin/release-4.9/e2e-gcp-builds 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/gcp-pd-csi-driver-operator/release-4.9/e2e-gcp-csi-migration 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/origin/release-4.9/e2e-gcp-disruptive 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/origin/release-4.9/e2e-aws-disruptive 5a0bb211ecc3db495c0e3bb1602f9577382a9b86 link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/release-4.9/e2e-azure-ovn-dualstack f510267 link /test pj-rehearse
ci/rehearse/openshift/origin/master/e2e-aws-single-node f510267 link /test pj-rehearse
ci/rehearse/openshift/cluster-logging-operator/tech-preview/e2e-operator f510267 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-aws-calico f510267 link /test pj-rehearse
ci/rehearse/openshift/origin/release-4.9/e2e-aws-single-node f510267 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-gcp-ovn f510267 link /test pj-rehearse
ci/rehearse/openshift/origin/release-4.10/e2e-aws-single-node-serial f510267 link /test pj-rehearse
ci/rehearse/openshift/origin/release-4.10/e2e-aws-single-node f510267 link /test pj-rehearse
ci/rehearse/openshift/kubernetes/release-4.9/e2e-openstack-csi-manila f510267 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-azure-ovn f510267 link /test pj-rehearse
ci/rehearse/openshift/kubernetes/release-4.9/configmap-scale f510267 link /test pj-rehearse
ci/rehearse/operator-framework/operator-marketplace/release-4.9/e2e-aws-serial f510267 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-azure-cilium f510267 link /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.9/azure-e2e-operator f510267 link /test pj-rehearse
ci/rehearse/operator-framework/operator-marketplace/release-4.9/e2e-aws-upgrade f510267 link /test pj-rehearse
ci/rehearse/openshift/cluster-etcd-operator/release-4.9/e2e-gcp-disruptive-ovn f510267 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade f510267 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-aws-upgrade-single-node f510267 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-azure-upgrade-single-node f510267 link /test pj-rehearse
ci/prow/pj-rehearse f510267 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.7-upgrade-from-stable-4.6-e2e-ovirt-upgrade f510267 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Aug 24, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit dc66188 into openshift:master Aug 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2021

@osherdp: Updated the following 4 configmaps:

  • ci-operator-4.9-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-priv-origin-release-4.9.yaml using file ci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.9.yaml
    • key openshift-origin-release-4.9.yaml using file ci-operator/config/openshift/origin/openshift-origin-release-4.9.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key ipi-install-install-commands.sh using file ci-operator/step-registry/ipi/install/install/ipi-install-install-commands.sh
    • key ipi-install-install-ref.yaml using file ci-operator/step-registry/ipi/install/install/ipi-install-install-ref.yaml
    • key ipi-install-install-stableinitial-ref.yaml using file ci-operator/step-registry/ipi/install/install/stableinitial/ipi-install-install-stableinitial-ref.yaml
    • key openshift-e2e-aws-single-node-workflow.yaml using file ci-operator/step-registry/openshift/e2e/aws/single-node/openshift-e2e-aws-single-node-workflow.yaml
    • key openshift-e2e-gcp-single-node-workflow.yaml using file ci-operator/step-registry/openshift/e2e/gcp/single-node/openshift-e2e-gcp-single-node-workflow.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-priv-origin-master.yaml using file ci-operator/config/openshift-priv/origin/openshift-priv-origin-master.yaml
    • key openshift-origin-master.yaml using file ci-operator/config/openshift/origin/openshift-origin-master.yaml
  • ci-operator-4.10-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-priv-origin-release-4.10.yaml using file ci-operator/config/openshift-priv/origin/openshift-priv-origin-release-4.10.yaml
    • key openshift-origin-release-4.10.yaml using file ci-operator/config/openshift/origin/openshift-origin-release-4.10.yaml
Details

In response to this:

Reverts #20592
/cc @deads2k @eranco74
/hold

I do think we didn't yet got the chance to use the artifacts (the bug is reproducing once a week or two), but let's have the revert ready for now and start thinking about our options.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@eranco74 eranco74 Awaiting requested review from eranco74

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@osherdp @deads2k @eranco74 @openshift-bot @openshift-merge-robot