make prow works mostly - #209
Merged
Merged
Conversation
Signed-off-by: Michalis Kargakis <mkargaki@redhat.com>
openshift-ci-robot
added
the
size/S
| oc create secret generic jenkins-tokens --from-literal=basic=${BASIC_AUTH_PASS} --from-literal=origin-bearer=${BEARER_TOKEN} -o yaml --dry-run | oc apply -n ci -f - | ||
| # HMAC_TOKEN is used for encrypting Github webhook payloads. | ||
| oc create secret generic hmac-token --from-literal=hmac=${HMAC_TOKEN} -o yaml --dry-run | oc apply -f - | ||
| oc create secret generic hmac-token --from-literal=hmac=${HMAC_TOKEN} -o yaml --dry-run | oc apply -n ci -f - |
Contributor
There was a problem hiding this comment.
not sure -n ci is appropriate here, would make local testing of this hard
Contributor
Author
There was a problem hiding this comment.
Yeah, not ideal but better than not defining the namespace and letting the config be created successfully in something that is not ci.
Contributor
Author
There was a problem hiding this comment.
Will push a fix that parameterizes this in the Makefile today or tomorrow.
derekhiggins
pushed a commit
to derekhiggins/release
that referenced
this pull request
Oct 24, 2023
Use current rdo ironic python agent tar
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.