-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[OCPCLOUD-1226] add cluster-api-provider-alibaba repository #20668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change was created by running `make new-repo` and following the prompts.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Fedosin ptal, just want to make sure i did this correctly =) |
|
@elmiko: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test app-ci-config-dry |
JoelSpeed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this sufficient to set up the merge requirements? IIRC there's some paritcular file that needs to be created to configure tide. Let's double check and include that if not already included
| image_stream_tag: | ||
| name: release | ||
| namespace: openshift | ||
| tag: golang-1.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| tag: golang-1.15 | |
| tag: golang-1.16 |
| - commandHelpLink: "" | ||
| repos: | ||
| - openshift/cluster-api-provider-alibaba | ||
| require_self_approval: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tend to require self approval on our team's repos
| require_self_approval: false | |
| require_self_approval: true |
did you mean a file here or in the target repo? |
|
@elmiko: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
IIRC there's some special configuration that has to go into this repo 🤔 @Fedosin you did this recently, have we got tide set up correctly? |
|
ack, i can review some of our other PRs |
|
this is outdated by #22459 |
This change was created by running
make new-repoand following the prompts.