cluster-launch-installer-e2e: Block tests on 'create cluster' #2062
Conversation
Don't run the tests before 'create cluster' exits successfully (if it fails, the /tmp/shared/exit check will kill the 'test' container). With this, we no longer have to wait on the shared kubeconfig, because we know it was created before setup-success. And once 'create cluster' successfully blocks on the bootstrap-complete event [1], this commit will ensure that we run our tests on the production control plane, and while the bootstrap control plane is still involved. [1]: openshift/installer#579 Although we've been seeing some issues with the re-watch logic from that pull request. Once that logic solidifies, we can drop the API_UP check as well.
openshift-ci-robot
added
size/S
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
Don't run the tests before
create clusterexits successfully (if it fails, the/tmp/shared/exitcheck will kill thetestcontainer). With this, we no longer have to wait on the sharedkubeconfig, because we know it was created beforesetup-success. And oncecreate clustersuccessfully blocks on the bootstrap-complete event (openshift/installer#579), this pull-request will ensure that we run our tests on the production control plane, and while the bootstrap control plane is still involved.We've been seeing some issues with the re-watch logic from (openshift/installer#579). Once that logic solidifies, we can drop the
API_UPcheck as well.CC @abhinavdahiya, @crawford