Skip to content

Conversation

@flaper87
Copy link
Contributor

@flaper87 flaper87 commented Nov 1, 2018

Sadly, the gophercloud/utils lib uses user.CurrentUser to load get the
user home dir. This fails with a panic error when used in environments
where such functionality is not available.

Let's set the USER env var for now until I fix this issue in
gophercloud.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 1, 2018
@flaper87
Copy link
Contributor Author

flaper87 commented Nov 1, 2018

/cc @sallyom

@wking
Copy link
Member

wking commented Nov 2, 2018

More on this issue in a different context here and in #1185. Should you set HOME too?

@flaper87
Copy link
Contributor Author

flaper87 commented Nov 2, 2018

@wking Thanks! I added HOME although I don't think I need it for this specific fix.

Sadly, the gophercloud/utils lib uses user.CurrentUser to load get the
user home dir. This fails with a panic error when used in environments
where such functionality is not available.

Let's set the `USER` env var for now until I fix this issue in
gophercloud.
@flaper87
Copy link
Contributor Author

flaper87 commented Nov 2, 2018

@wking done! Thanks a bunch for the review 😃

Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flaper87, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2018
@openshift-merge-robot openshift-merge-robot merged commit d4b9609 into openshift:master Nov 2, 2018
@openshift-ci-robot
Copy link
Contributor

@flaper87: Updated the prow-job-cluster-launch-installer-e2e configmap using the following files:

  • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
Details

In response to this:

Sadly, the gophercloud/utils lib uses user.CurrentUser to load get the
user home dir. This fails with a panic error when used in environments
where such functionality is not available.

Let's set the USER env var for now until I fix this issue in
gophercloud.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants