Skip to content

cluster-launch-installer-e2e: Change 'destroy-cluster' -> 'destroy cluster' #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 26, 2018
Merged

cluster-launch-installer-e2e: Change 'destroy-cluster' -> 'destroy cluster' #1987

openshift-merge-robot merged 1 commit into from
Oct 26, 2018

Conversation

@wking
Copy link
Member

@wking wking commented Oct 22, 2018

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 22, 2018
@wking
Copy link
Member Author

wking commented Oct 23, 2018

I've pushed 694e8ca -> c41a240, changing cluster -> create cluster to catch up with openshift/installer#513.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 26, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2018
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2018
@wking
Copy link
Member Author

wking commented Oct 26, 2018

Rebased around #2030 with c41a240 -> 9084cb1.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 26, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2018
@wking
cluster-launch-installer-e2e: Change 'destroy-cluster' -> 'destroy cl…
121a597 
…uster'

Catching up with openshift/installer@3f4fe574 (cmd/openshift-install:
Add 'destroy bootstrap' command, openshift/installer#493).

Also change 'cluster' -> 'create cluster' to catch up with
openshift/installer@85c76c98 (cmd/openshift-install: Push creation
under 'openshift create', 2018-10-22, openshift/installer#513).
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2018
@wking
Copy link
Member Author

wking commented Oct 26, 2018

Rebased around #2031 with 9084cb1 -> 121a597 :p.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 26, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c6d7491 into openshift:master Oct 26, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 26, 2018

@wking: Updated the prow-job-cluster-launch-installer-e2e configmap using the following files:

  • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
Details

In response to this:

Catching up with openshift/installer@3f4fe574 (openshift/installer#493).

/assign @abhinavdahiya

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the destroy-cluster branch October 30, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@staebler staebler Awaiting requested review from staebler

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wking @abhinavdahiya @openshift-ci-robot @openshift-merge-robot