Show container output for e2e, upgrade and openshift-ansible templates

[vrutkovs]

Use annotation, implemented in openshift/ci-operator#184, to show container output in the log if subsequent containers fail (e.g. tests)

[droslean]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [droslean]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@vrutkovs: Updated the following 3 configmaps:

• prow-job-cluster-launch-e2e-openshift-ansible configmap using the following files:
  • key cluster-launch-e2e-openshift-ansible.yaml using file ci-operator/templates/cluster-launch-e2e-openshift-ansible.yaml
• prow-job-cluster-launch-e2e-upgrade configmap using the following files:
  • key cluster-launch-e2e-upgrade.yaml using file ci-operator/templates/cluster-launch-e2e-upgrade.yaml
• prow-job-cluster-launch-e2e configmap using the following files:
  • key cluster-launch-e2e.yaml using file ci-operator/templates/cluster-launch-e2e.yaml

Details

In response to this:

Use annotation, implemented in openshift/ci-operator#184, to show container output in the log if subsequent containers fail (e.g. tests)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bbguimaraes]

@droslean: please stop accepting PRs that use the wrong implementation of the annotation. We want to be explicit about which containers have their logs captured, not blindly add all (existing and future) containers with a single annotation.

Every change that's being added now will have to be reconsidered and changed once we fix the API.