Skip to content

Conversation

@ramr
Copy link
Contributor

@ramr ramr commented Oct 17, 2018

As per issues noticed in openshift/installer#467
The method for setting the router namespace needs to change routers started by the cluster ingress operator - otherwise it is checking the default namespace.

@smarterclayton @ironcladlou PTAL thx

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2018
@crawford
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, ramr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2018
@abhinavdahiya
Copy link
Contributor

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2018
@openshift-merge-robot openshift-merge-robot merged commit f541bc0 into openshift:master Oct 17, 2018
@openshift-ci-robot
Copy link
Contributor

@ramr: Updated the prow-job-cluster-launch-installer-e2e configmap using the following files:

  • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
Details

In response to this:

As per issues noticed in openshift/installer#467
The method for setting the router namespace needs to change routers started by the cluster ingress operator - otherwise it is checking the default namespace.

@smarterclayton @ironcladlou PTAL thx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crawford
Copy link
Contributor

@abhinavdahiya's concern was that the object the script waits for doesn't seem to be correct. It always looks for deploy/router.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants