Refactor ipi-conf-aws to run under different accounts #18638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
e-tienne
force-pushed
the
aws-conf-multiple-accounts
branch
2 times, most recently
from
807b6c8 to
7dde0b5
Compare
Member
|
/test pj-rehearse |
Member
|
@wking The rehearsals passed. Can you check on the details? |
Contributor
Author
|
/retitle Refactor ipi-conf-aws to run under different accounts |
openshift-ci
bot
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/cc staebler |
Contributor
Author
|
/retest |
openshift-ci
bot
added
the
needs-rebase
staebler
reviewed
May 26, 2021
Contributor
staebler
left a comment
staebler
left a comment
There was a problem hiding this comment.
Looks pretty good to me. I have mostly nits.
...erator/step-registry/ipi/conf/aws/blackholenetwork/ipi-conf-aws-blackholenetwork-commands.sh
Outdated
Show resolved
Hide resolved
...erator/step-registry/ipi/conf/aws/blackholenetwork/ipi-conf-aws-blackholenetwork-commands.sh
Outdated
Show resolved
Hide resolved
...erator/step-registry/ipi/conf/aws/blackholenetwork/ipi-conf-aws-blackholenetwork-commands.sh
Outdated
Show resolved
Hide resolved
...gistry/ipi/deprovision/aws/blackholenetwork/ipi-deprovision-aws-blackholenetwork-commands.sh
Outdated
Show resolved
Hide resolved
...erator/step-registry/ipi/conf/aws/blackholenetwork/ipi-conf-aws-blackholenetwork-commands.sh
Outdated
Show resolved
Hide resolved
ci-operator/step-registry/ipi/conf/aws/sharednetwork/ipi-conf-aws-sharednetwork-commands.sh
Outdated
Show resolved
Hide resolved
...erator/step-registry/ipi/conf/aws/blackholenetwork/ipi-conf-aws-blackholenetwork-commands.sh
Outdated
Show resolved
Hide resolved
ci-operator/step-registry/ipi/conf/aws/ipi-conf-aws-commands.sh
Outdated
Show resolved
Hide resolved
ci-operator/step-registry/ipi/conf/aws/ipi-conf-aws-commands.sh
Outdated
Show resolved
Hide resolved
e-tienne
force-pushed
the
aws-conf-multiple-accounts
branch
from
ab904cb to
99e41c4
Compare
openshift-ci
bot
removed
the
needs-rebase
Contributor
Author
|
/retest |
Contributor
|
/lgtm cancel |
Contributor
|
@e-tienne This LGTM. Can you squash down the commits? |
Pick availability zones at runtime and add minimum requirements Create, use and destroy VPC it's dependencies on demand for step jobs Remove hardcoding in the ipi-conf-aws-blackholenetwork step Remove hardcoding in ipi-conf-aws-sharednetwork step https://issues.redhat.com/browse/CORS-1704
e-tienne
force-pushed
the
aws-conf-multiple-accounts
branch
from
59d8c36 to
8f72204
Compare
Contributor
Author
Squashed! Thanks for the review. |
Contributor
|
@e-tienne: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: e-tienne, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
@e-tienne: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/CORS-1704