Skip to content

Add openshift/build-test-images to tide #18523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 14, 2021
Merged

Add openshift/build-test-images to tide #18523

openshift-merge-robot merged 1 commit into from
May 14, 2021

Conversation

@adambkaplan
Copy link
Contributor

@adambkaplan adambkaplan commented May 12, 2021

  • Build simples2i image in addition to roots2i image
  • Add build-test-images repo to tide, add approve plugin
  • Add e2e-aws and e2e-aws-builds suites to tests

@adambkaplan
Add build-test-images to tide
817bd72 
- Build simples2i image in addition to roots2i image
- Add build-test-images repo to tide, add approve plugin
- Add e2e-aws and e2e-aws-builds suites to tests
@adambkaplan adambkaplan mentioned this pull request May 12, 2021
Merged
@openshift-ci openshift-ci bot requested review from bparees and gabemontero May 12, 2021 16:13
@adambkaplan
Copy link
Contributor Author

adambkaplan commented May 12, 2021

/assign @alvaroaleman

@adambkaplan
Copy link
Contributor Author

adambkaplan commented May 12, 2021

/cc @bparees @alicerum @yselkowitz

@openshift-ci openshift-ci bot requested review from alicerum and yselkowitz May 12, 2021 16:14
alvaroaleman
alvaroaleman approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@alvaroaleman alvaroaleman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the prow config changes
/hold
cancel at your convenience

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels May 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2021
@yselkowitz
Copy link
Contributor

yselkowitz commented May 12, 2021

What benefit is there to adding these images to registry.ci? Since openshift internal registries do not support manifest lists, I'm worried that even if we were to build and push the redhat-developer build multi-arch enabled, if it goes through registry.ci, we'll only get x86 mirrored into openshift/community-e2e-images, and we'll still need a multi-arch override for testing. Why can't the redhat-developer build (with a versioned tag) be mirrored directly without going through registry.ci?

@adambkaplan
Copy link
Contributor Author

adambkaplan commented May 12, 2021

What benefit is there to adding these images to registry.ci?

@yselkowitz adding the images to registry.ci was based on @gabemontero's comment here. We are already pushing the roots2i image, how is the simples2i image any different? How are multiarch images published to quay.io otherwise?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2021

@adambkaplan: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/build-test-images/master/e2e-aws 817bd72 link /test pj-rehearse
ci/rehearse/openshift/build-test-images/release-4.8/e2e-aws 817bd72 link /test pj-rehearse
ci/rehearse/openshift/build-test-images/master/e2e-aws-builds 817bd72 link /test pj-rehearse
ci/rehearse/openshift/build-test-images/release-4.9/e2e-aws-builds 817bd72 link /test pj-rehearse
ci/rehearse/openshift/build-test-images/release-4.8/e2e-aws-builds 817bd72 link /test pj-rehearse
ci/rehearse/openshift/build-test-images/release-4.9/e2e-aws 817bd72 link /test pj-rehearse
ci/prow/pj-rehearse 817bd72 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gabemontero
Copy link
Contributor

gabemontero commented May 13, 2021

What benefit is there to adding these images to registry.ci?

@yselkowitz adding the images to registry.ci was based on @gabemontero's comment here. We are already pushing the roots2i image, how is the simples2i image any different? How are multiarch images published to quay.io otherwise?

Yep, following the pattern we started with roots2i (in hindsight, we should have done both when we were in here last time).
This pattern stemmed from interactions between @bparees and I with Clayton.

Among other things, it makes running our e2e in disconnected more seamless.

@gabemontero
Copy link
Contributor

gabemontero commented May 13, 2021

the failure at https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/18523/rehearse-18523-pull-ci-openshift-build-test-images-master-e2e-aws-builds/1392513319411126272 was the known verify /run based on recent node team changes

still catching up on email, but this is mergeable IMO based on manual testing and what we see here with e2e-gcp-builds

@adambkaplan
Copy link
Contributor Author

adambkaplan commented May 14, 2021

/hold cancel

/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit ccaf2be into openshift:master May 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2021

@adambkaplan: Updated the following 8 configmaps:

  • job-config-4.8 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-build-test-images-release-4.8-presubmits.yaml using file ci-operator/jobs/openshift/build-test-images/openshift-build-test-images-release-4.8-presubmits.yaml
  • job-config-4.9 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-build-test-images-release-4.9-presubmits.yaml using file ci-operator/jobs/openshift/build-test-images/openshift-build-test-images-release-4.9-presubmits.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-build-test-images-master.yaml using file ci-operator/config/openshift/build-test-images/openshift-build-test-images-master.yaml
  • ci-operator-4.8-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-build-test-images-release-4.8.yaml using file ci-operator/config/openshift/build-test-images/openshift-build-test-images-release-4.8.yaml
  • ci-operator-4.9-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-build-test-images-release-4.9.yaml using file ci-operator/config/openshift/build-test-images/openshift-build-test-images-release-4.9.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-build-test-images-master-presubmits.yaml using file ci-operator/jobs/openshift/build-test-images/openshift-build-test-images-master-presubmits.yaml
Details

In response to this:

  • Build simples2i image in addition to roots2i image
  • Add build-test-images repo to tide, add approve plugin
  • Add e2e-aws and e2e-aws-builds suites to tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero mentioned this pull request May 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@gabemontero gabemontero Awaiting requested review from gabemontero

@alicerum alicerum Awaiting requested review from alicerum

@yselkowitz yselkowitz Awaiting requested review from yselkowitz

1 more reviewer

@alvaroaleman alvaroaleman alvaroaleman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alvaroaleman alvaroaleman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adambkaplan @yselkowitz @gabemontero @alvaroaleman @openshift-merge-robot