Skip to content

e2e-aws master: remove extra space in TEST_SKIP#1813

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
vrutkovs:oa-aws-master-space
Oct 4, 2018
Merged

e2e-aws master: remove extra space in TEST_SKIP#1813
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
vrutkovs:oa-aws-master-space

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Oct 4, 2018

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 4, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2018
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Oct 4, 2018

@stevekuznetsov the tests fail and suggest to split this line - which is incorrect. Should I use env vars instead or Prow tests should be fixed?

@stevekuznetsov
Copy link
Contributor

Why is it incorrect?

$ cat /tmp/test.yaml 
key: value that is on
  multiple lines
$ python
Python 2.7.13 (default, May 10 2017, 20:04:28) 
[GCC 6.3.1 20161221 (Red Hat 6.3.1-1)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import yaml
>>> with open("/tmp/test.yaml") as f:
...     data = yaml.load(f)
... 
>>> data["key"]
'value that is on multiple lines'

@stevekuznetsov
Copy link
Contributor

Perhaps it's '(\\[' being wrong and you need "(\\[" or '(\['? For what it's worth, you are the only test with \\[

@stevekuznetsov
Copy link
Contributor

I would suggest changing to '(\[' to match the rest

@vrutkovs vrutkovs force-pushed the oa-aws-master-space branch 6 times, most recently from 5e556cc to 4bfb480 Compare October 4, 2018 15:24
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Oct 4, 2018

value: | was the trick

@vrutkovs vrutkovs force-pushed the oa-aws-master-space branch 4 times, most recently from 1690e42 to d3cb2fe Compare October 4, 2018 15:54
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 4, 2018
@vrutkovs vrutkovs force-pushed the oa-aws-master-space branch 2 times, most recently from 1e76180 to dd4cad7 Compare October 4, 2018 16:08
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 4, 2018
This fixed a list of skipped tests for e2e-aws job
@vrutkovs vrutkovs force-pushed the oa-aws-master-space branch from dd4cad7 to 28eb961 Compare October 4, 2018 16:12
@vrutkovs vrutkovs force-pushed the oa-aws-master-space branch from 4c2c029 to fa3cdad Compare October 4, 2018 16:29
@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 949642e into openshift:master Oct 4, 2018
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: Updated the job-config configmap using the following files:

  • key openshift-openshift-ansible-release-3.11-presubmits.yaml using file ci-operator/jobs/openshift/openshift-ansible/openshift-openshift-ansible-release-3.11-presubmits.yaml
  • key openshift-openshift-ansible-master-presubmits.yaml using file ci-operator/jobs/openshift/openshift-ansible/openshift-openshift-ansible-master-presubmits.yaml
Details

In response to this:

This fixed a list of skipped tests for e2e-aws job. This fixes https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_openshift-ansible/9990/pull-ci-openshift-openshift-ansible-master-e2e-aws/28/build-log.txt - some tests were not skipped

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs deleted the oa-aws-master-space branch May 16, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants