Skip to content

Conversation

@smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Oct 1, 2018

We will re-enable a more accurate signal for "cluster is ready" in
the near term. Until then we don't need this wait.

Enables us to merge openshift/installer#330 while we go through a period of churn in install.

We will re-enable a more accurate signal for "cluster is ready" in
the near term. Until then we don't need this wait.
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 1, 2018
@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2018
@derekwaynecarr
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cd04e7e into openshift:master Oct 1, 2018
@openshift-ci-robot
Copy link
Contributor

@smarterclayton: Updated the prow-job-cluster-launch-installer-e2e configmap using the following files:

  • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/cluster-launch-installer-e2e.yaml
Details

In response to this:

We will re-enable a more accurate signal for "cluster is ready" in
the near term. Until then we don't need this wait.

Enables us to merge openshift/installer#330 while we go through a period of churn in install.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarterclayton smarterclayton deleted the remove_router_check branch April 24, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants