Skip to content

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented Sep 28, 2018

@wking @stevekuznetsov cluster/test-deploy/aws/openshift.yaml no longer exists :)

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 28, 2018
@bbguimaraes
Copy link
Contributor

The aws profile is used by openshift-ansible:

- name: cluster-profile
projected:
sources:
- secret:
name: cluster-secrets-aws
- configMap:
name: cluster-profile-aws

- name: cluster-profile
projected:
sources:
- secret:
name: cluster-secrets-aws
- configMap:
name: cluster-profile-aws

@sallyom
Copy link
Contributor Author

sallyom commented Sep 28, 2018

@bbguimaraes that's our openshift/installer job, I've removed that reference in this PR. The openshift.yaml is the config that was specific to tectonic, @wking removed it in a previous PR: https://github.com/openshift/release/pull/1677/files
ack never fails me..

@bbguimaraes
Copy link
Contributor

Wow, I mixed that up. It was used in the past but I see it's a different profile now. Sorry for the noise, this

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, sallyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2018
@openshift-merge-robot openshift-merge-robot merged commit 941ebf5 into openshift:master Sep 28, 2018
@openshift-ci-robot
Copy link
Contributor

@sallyom: Updated the following 2 configmaps:

  • job-config configmap using the following files:
    • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
  • plugins configmap using the following files:
    • key plugins.yaml using file cluster/ci/config/prow/plugins.yaml
Details

In response to this:

@wking @stevekuznetsov cluster/test-deploy/aws/openshift.yaml no longer exists :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking added a commit to wking/openshift-release that referenced this pull request Sep 29, 2018
Like d44e106 (remove ref to openshift.yaml aws installer config,
2018-09-27, openshift#1755), this is cleaning up after 3f2f01c
(ci-operator/config/openshift/installer/master: Move to
openshift-install, 2018-09-26, openshift#1677).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants