Skip to content

Conversation

@stevekuznetsov
Copy link
Contributor

/assign @smarterclayton

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 26, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2018
@stevekuznetsov
Copy link
Contributor Author

Fixes mistakes, pulls out images presubmit. Needs migration:

bazel run //maintenance/migratestatus -- --org openshift --repo installer --move ci/prow/go-fmt --dest ci/prow/gofmt --dry-run=false --continue-on-error --logtostderr
bazel run //maintenance/migratestatus -- --org openshift --repo installer --move ci/prow/go-vet --dest ci/prow/govet --dry-run=false --continue-on-error --logtostderr

@stevekuznetsov stevekuznetsov added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2018
@openshift-merge-robot openshift-merge-robot merged commit d51b6e2 into openshift:master Sep 26, 2018
@openshift-ci-robot
Copy link
Contributor

@stevekuznetsov: Updated the job-config configmap using the following files:

  • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
  • key openshift-installer-release-3.11-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-release-3.11-presubmits.yaml
Details

In response to this:

/assign @smarterclayton

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

always_run: true
branches:
- master
context: ci/prow/images
Copy link
Member

@wking wking Sep 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job is always failing for us, with:

error: unable to upload new layer (0): Patch https://registry.svc.ci.openshift.org/v2/ci-op-43zwvfh8/release/blobs/uploads/dcf4557c-9a87-4aa4-9d77-e3acdd113040?_state=gJbjHXXdyNlVUJgCRicnvCShiBRmwSEuX5WyHCwyJgt7Ik5hbWUiOiJjaS1vcC00M3p3dmZoOC9yZWxlYXNlIiwiVVVJRCI6ImRjZjQ1NTdjLTlhODctNGFhNC05ZDc3LWUzYWNkZDExMzA0MCIsIk9mZnNldCI6MCwiU3RhcnRlZEF0IjoiMjAxOC0wOS0yN1QwMDowMjowMS45ODg1MTQ2OTFaIn0%3D: operator "catalog" failed to map images: yaml: line 16: mapping values are not allowed in this context

Can we drop this job, or at least make it optional, until we get that sorted?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it fails randomly, the last two runs (17, 18) were successful.

@smarterclayton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants