Skip to content

templates/installer: copy artifacts after install #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Sep 22, 2018
Merged

templates/installer: copy artifacts after install #1630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ci-operator/templates/cluster-launch-installer-e2e-smoke.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,10 @@ objects:
cd /tmp/cluster
tectonic init --config=inputs.yaml
mv -f ${NAME}/* /tmp/cluster/
cp config.yaml internal.yaml terraform.tfvars /tmp/artifacts/installer/
cp config.yaml internal.yaml /tmp/artifacts/installer/
Copy link
Member

@wking wking Sep 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to get these even if install fails. Maybe put it in an EXIT trap like this to copy this asset out regardless of install success?

Copy link
Contributor Author

@crawford crawford Sep 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather we keep this dead simple since it's holding up some PRs that have to go in. Once those merge, I'm going to come back and update all of this to work with the new installer.


tectonic install --dir=. --log-level=debug
cp terraform.tfvars /tmp/artifacts/installer/

# wait until oc shows up
while true; do
Expand Down
3 changes: 2 additions & 1 deletion ci-operator/templates/cluster-launch-installer-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,10 @@ objects:
cd /tmp/cluster
tectonic init --config=inputs.yaml
mv -f ${NAME}/* /tmp/cluster/
cp config.yaml internal.yaml terraform.tfvars /tmp/artifacts/installer/
cp config.yaml internal.yaml /tmp/artifacts/installer/

tectonic install --dir=. --log-level=debug
cp terraform.tfvars /tmp/artifacts/installer/

# wait until oc shows up
while true; do
Expand Down