Skip to content

openshift/origin: add tests for metal ipi platform #15816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 25, 2021
Merged

openshift/origin: add tests for metal ipi platform #15816

openshift-merge-robot merged 1 commit into from
Feb 25, 2021

Conversation

@andfasano
Copy link
Contributor

@andfasano andfasano commented Feb 12, 2021 •
edited
Loading

This tests could be useful to verify that adding new e2e tests (in particular for the baremetal platform) will pass also on the metal ipi platform.

See also openshift/origin#25853

@andfasano
Copy link
Contributor Author

andfasano commented Feb 12, 2021

/cc @stbenjam @ardaguclu

@ardaguclu
Copy link
Member

ardaguclu commented Feb 12, 2021

Does that trigger when new PR is opened to master from another branch in origin?, or after being merged to master.

@andfasano
Copy link
Contributor Author

andfasano commented Feb 12, 2021

Does that trigger when new PR is opened to master from another branch in origin?, or after being merged to master.

Presubmit jobs are triggered before

@andfasano andfasano mentioned this pull request Feb 12, 2021
Merged
@stbenjam
Copy link
Member

stbenjam commented Feb 12, 2021

Will you update the test list to include Feature:baremetal or wait until the PR is merged? I thought it'd be fine to include a match for a test that might not exist yet

@andfasano
Copy link
Contributor Author

andfasano commented Feb 12, 2021

Will you update the test list to include Feature:baremetal or wait until the PR is merged? I thought it'd be fine to include a match for a test that might not exist yet

I was waiting for this PR to get merged first, but effectively I can update the test lists meanwhile, it should be fine

@stbenjam
Copy link
Member

stbenjam commented Feb 12, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2021
@andfasano
Copy link
Contributor Author

andfasano commented Feb 15, 2021

/test pj-rehearse

@andfasano
Copy link
Contributor Author

andfasano commented Feb 15, 2021

/assign @deads2k

@andfasano
Copy link
Contributor Author

andfasano commented Feb 15, 2021

/test pj-rehearse

@andfasano
Copy link
Contributor Author

andfasano commented Feb 15, 2021

/assign @sttts

@sttts
Copy link
Contributor

sttts commented Feb 15, 2021

What does "will pass also on the metal ipi platform." mean?

sttts
sttts reviewed Feb 15, 2021
View reviewed changes
@andfasano
Copy link
Contributor Author

andfasano commented Feb 15, 2021

What does "will pass also on the metal ipi platform." mean?

The basic idea is that whenever there will be the need of adding a new e2e test for the baremetal platform (like the two in the openshift/origin#25853) it could be possible to verify in the PR that the newly added tests:

  • Pass successfully on any e2e-metal-ipi-* job
  • Are skipped on all the other jobs

@andfasano andfasano force-pushed the enable-metal-ipi-test-origin branch from e023ed3 to a6be0fc Compare February 16, 2021 17:53
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2021
@andfasano
Copy link
Contributor Author

andfasano commented Feb 17, 2021

/test pj-rehearse

1 similar comment
@andfasano
Copy link
Contributor Author

andfasano commented Feb 17, 2021

/test pj-rehearse

@andfasano andfasano closed this Feb 17, 2021
@andfasano andfasano reopened this Feb 17, 2021
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2021
@andfasano andfasano force-pushed the enable-metal-ipi-test-origin branch from a6be0fc to f3ad3b5 Compare February 17, 2021 11:23
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2021
@andfasano
Copy link
Contributor Author

andfasano commented Feb 18, 2021

@sttts Above failures look to be not related to the e2e-metal-ipi jobs, which succeeded

@andfasano andfasano requested a review from sttts February 19, 2021 17:48
sttts
sttts reviewed Feb 19, 2021
View reviewed changes
ci-operator/config/openshift/origin/openshift-origin-master.yaml Outdated
Copy link
Contributor

@sttts sttts Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for what is this used?

Copy link
Member

@stbenjam stbenjam Feb 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Development environment for baremetal, it's used by our CI to emulate various baseboard management controllers, and emulate baremetal hosts as virtual machines to reduce the footprint of our CI.

Copy link
Contributor Author

@andfasano andfasano Feb 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And without that image all the e2e-metal-ipi workflows couldn't work, since it's used in the baremetalds-devscript-setup step

@stbenjam
Copy link
Member

stbenjam commented Feb 22, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2021
@stbenjam
Copy link
Member

stbenjam commented Feb 22, 2021

@stts Can you take another look please?

@andfasano andfasano force-pushed the enable-metal-ipi-test-origin branch from f3ad3b5 to 550ef24 Compare February 25, 2021 11:27
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021
@andfasano
Copy link
Contributor Author

andfasano commented Feb 25, 2021

/test pj-rehearse

1 similar comment
@andfasano
Copy link
Contributor Author

andfasano commented Feb 25, 2021

/test pj-rehearse

@stbenjam
Copy link
Member

stbenjam commented Feb 25, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021
@stbenjam
Copy link
Member

stbenjam commented Feb 25, 2021

/assign @sttts

Could you have another look please?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2021

@andfasano: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-baremetal-operator/release-4.6/e2e-metal-ipi e023ed3de0a79c31af6c5448a3d13cc6c454d63f link /test pj-rehearse
ci/rehearse/openshift/origin/master/e2e-openstack-serial f3ad3b58323fc4e8b2f09e877679a562445b2c53 link /test pj-rehearse
ci/prow/pj-rehearse f3ad3b58323fc4e8b2f09e877679a562445b2c53 link /test pj-rehearse
ci/rehearse/openshift/cluster-api-provider-baremetal/master/e2e-metal-ipi-upgrade 550ef24 link /test pj-rehearse
ci/rehearse/openshift/origin/master/okd-e2e-gcp 550ef24 link /test pj-rehearse
ci/rehearse/openshift/origin/master/e2e-aws-jenkins 550ef24 link /test pj-rehearse
ci/rehearse/openshift/origin/master/e2e-agnostic-cmd 550ef24 link /test pj-rehearse
ci/rehearse/openshift/origin/master/e2e-aws-fips 550ef24 link /test pj-rehearse
ci/rehearse/openshift/origin/master/e2e-aws-proxy 550ef24 link /test pj-rehearse
ci/rehearse/openshift/origin/master/e2e-gcp-builds 550ef24 link /test pj-rehearse
ci/rehearse/openshift/origin/master/e2e-aws-upgrade 550ef24 link /test pj-rehearse
ci/rehearse/openshift/origin/master/e2e-gcp-disruptive 550ef24 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hongkailiu
Copy link
Member

hongkailiu commented Feb 25, 2021

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, hongkailiu, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9cae993 into openshift:master Feb 25, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 25, 2021

@andfasano: Updated the following 5 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-master.yaml using file ci-operator/config/openshift/origin/openshift-origin-master.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-origin-master-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-master-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-master-presubmits.yaml
  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key baremetalds-e2e-conf-commands.sh using file ci-operator/step-registry/baremetalds/e2e/conf/baremetalds-e2e-conf-commands.sh
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key baremetalds-e2e-conf-commands.sh using file ci-operator/step-registry/baremetalds/e2e/conf/baremetalds-e2e-conf-commands.sh
Details

In response to this:

This tests could be useful to verify that adding new e2e tests (in particular for the baremetal platform) will pass also on the metal ipi platform.

See also openshift/origin#25853

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam stbenjam deleted the enable-metal-ipi-test-origin branch February 25, 2021 18:56
@adambkaplan
Copy link
Contributor

adambkaplan commented Apr 9, 2021

@andfasano was the metal-ipi-ovn-ipv6 test intended to be run on every PR in origin? Or are these an optional test?

The current job history suggests that this test is very flaky and is not suitable to block merges in origin.

https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6?buildId=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@stbenjam stbenjam Awaiting requested review from stbenjam

@sjenning sjenning Awaiting requested review from sjenning

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@sttts sttts sttts left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@stbenjam stbenjam

@sttts sttts

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@andfasano @ardaguclu @stbenjam @sttts @hongkailiu @openshift-ci-robot @openshift-bot @adambkaplan @deads2k @openshift-merge-robot