We do not need patch manager approval for cherry picks for Cincinnati #15179
Conversation
As these are not part of OpenShift release payload and we build these in CPaaS and released separately Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty
force-pushed
the
remove_cherrypick_approvals_for_Cincy_repos
branch
from
51c44f2 to
564e6ff
Compare
|
/hold I think that removes all restrictions. Instead we want to be moved to a different group without |
openshift-ci-robot
added
the
do-not-merge/hold
|
@vrutkovs It is already part of that group check https://github.com/openshift/release/blob/master/core-services/prow/02_config/_config.yaml#L1610-L1611 Also you might want to check the PR which introduced it openshift/cincinnati#314 |
|
Ah, right. /hold cancel Not sure why |
openshift-ci-robot
removed
the
do-not-merge/hold
Signed-off-by: Lalatendu Mohanty <[email protected]>
Re-ran |
|
/lgtm |
|
/approve |
|
@petr-muller ptal |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, petr-muller, sdodson, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@LalatenduMohanty: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…nches 564e6ff (We do not need patch manager approval for cherry picks for Cincinnati, 2020-01-22, openshift#15179) removed our existing release-branch block without adding us to a different release-branch block. Here is where we are today: $ yaml2json <core-services/prow/02_config/_config.yaml | jq -r '.tide.queries[] | {labels, includedBranches, excludedBranches, repos: [(.repos // [])[] | select(contains("openshift/cincinnati"))]} | select((.repos | length) > 0)' { "labels": [ "lgtm", "approved" ], "includedBranches": [ "master", "main" ], "excludedBranches": null, "repos": [ "openshift/cincinnati", "openshift/cincinnati-operator" ] } { "labels": [ "lgtm", "approved", "bugzilla/valid-bug", "group-lead-approved" ], "includedBranches": [ "release-4.8", "openshift-4.8" ], "excludedBranches": null, "repos": [ "openshift/cincinnati", "openshift/cincinnati-operator" ] } { "labels": [ "lgtm", "approved" ], "includedBranches": null, "excludedBranches": [ "release-3.11", "release-4.0", "release-4.1", "release-4.2", "release-4.3", "release-4.4", "release-4.5", "release-4.6", "release-4.7", "release-4.8", "openshift-4.1", "openshift-4.2", "openshift-4.3", "openshift-4.4", "openshift-4.5", "openshift-4.6", "openshift-4.7", "openshift-4.8", "feature-es6x", "feature-prom-connector", "master", "main" ], "repos": [ "openshift/cincinnati", "openshift/cincinnati-operator" ] } { "labels": [ "lgtm", "approved" ], "includedBranches": null, "excludedBranches": null, "repos": [ "openshift/cincinnati-graph-data" ] } So cincinnati and cincinnati-operator had: * lgtm and approved for master and main (great) * lgtm, approved, valid-bug, and group-lead-approved for 4.8 (not what we want) * lgtm and approved for unrecognized branches (who cares?) * no Tide config for older release branches (not what we want). With this commit, I'm moving all of the Cincinnati entries under the "lgtm and approved for all branches" block. I'm not sure why we only have the one openshift-priv entry. It's originally from 4e4cd48 (private-prow-configs-mirror --release-repo-path, 2020-04-24, openshift#8553). In this commit, I'm just manually moving it alongside the other entries.
6 participants
As these are not part of OpenShift release payload and we build these in CPaaS and
released separately
Signed-off-by: Lalatendu Mohanty [email protected]