Skip to content

make installer smoke_test images optional in config #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 14, 2018
Merged

make installer smoke_test images optional in config #1487

openshift-merge-robot merged 1 commit into from
Sep 14, 2018

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented Sep 13, 2018 •
edited
Loading

@stevekuznetsov @smarterclayton
building smoke-test specific images slows all other tests way down, so making the smoke_test specific images optional

From what I'm seeing, the optional images always build but the rest of the job is not held up waiting for them if they're not required. Where's the documentation for this? Looking...thanks
Found it: https://github.com/openshift/ci-operator/blob/master/CONFIGURATION.md#imagesnameoptional
Docs don't reflect the behavior I'm seeing though, or maybe I'm missing something. Anyways, with this PR, non-smoke tests take less time to complete.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2018
@sallyom sallyom force-pushed the separate-config-smoke branch from 0373133 to 3b858a0 Compare September 13, 2018 22:34
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2018
@sallyom sallyom changed the title Separate master.yaml for e2e-aws and master-smoke.yaml for e2e-aws-smoke installer/set smoke_tests images for e2e-aws-smoke optional so they don't slow down e2e-aws Sep 13, 2018
@sallyom sallyom changed the title installer/set smoke_tests images for e2e-aws-smoke optional so they don't slow down e2e-aws [WIP]Separate master.yaml for e2e-aws and master-smoke.yaml for e2e-aws-smoke Sep 13, 2018
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2018
@sallyom sallyom changed the title [WIP]Separate master.yaml for e2e-aws and master-smoke.yaml for e2e-aws-smoke [WIP] make installer smoke_test images optional in config Sep 13, 2018
@sallyom sallyom force-pushed the separate-config-smoke branch from 3b858a0 to 02fac40 Compare September 13, 2018 22:54
@sallyom sallyom changed the title [WIP] make installer smoke_test images optional in config make installer smoke_test images optional in config Sep 13, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2018
@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Sep 14, 2018

What is your dependency tree, what are the targets you explicitly request and what are the targets that are actually built where you would not have expected them to be built? That's worth a bug report to openshift/release in an issue. This PR
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 14, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2018
@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Sep 14, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit 6e3b311 into openshift:master Sep 14, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 14, 2018

@sallyom: Updated the ci-operator-openshift-installer configmap using the following files:

  • key master.yaml using file ci-operator/config/openshift/installer/master.yaml
Details

In response to this:

@stevekuznetsov @smarterclayton
building smoke-test specific images slows all other tests way down, so making the smoke_test specific images optional

From what I'm seeing, the optional images always build but the rest of the job is not held up waiting for them if they're not required. Where's the documentation for this? Looking...thanks
Found it: https://github.com/openshift/ci-operator/blob/master/CONFIGURATION.md#imagesnameoptional
Docs don't reflect the behavior I'm seeing though, or maybe I'm missing something. Anyways, with this PR, non-smoke tests take less time to complete.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking mentioned this pull request Sep 14, 2018
Merged
@wking wking mentioned this pull request Sep 14, 2018
Merged
wking added a commit to wking/openshift-release that referenced this pull request Sep 14, 2018
@wking
Revert "Make smoke test images for e2e-aws-smoke optional, so they do…
fcfdafa 
…n't slow down e2e-aws"

This reverts commit 02fac40, openshift#1487.

Something funny was going on with optional [1], which resulted in
50a2396 (installer smoke_tests use LOCAL_IMAGE for optional
installer-smoke image, 2018-09-14, openshift#1517).  With 50a2396 reverted in
the previous commit, we'll want to revert this one too until we figure
out what was going on with both of them.

[1]: openshift#1517 (comment)
derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
@honza
Add padding to pass rates script output (openshift#1487)
d8377aa 
* Add padding to pass rates output

* Make shebang portable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

Assignees

@stevekuznetsov stevekuznetsov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sallyom @stevekuznetsov @openshift-ci-robot @openshift-merge-robot