Run E2E AWS single node variant on machine-config-operator presubmit #14756

omertuc · 2021-01-11T15:45:37Z

Based on #15187

kikisdeliveryservice

You also need to update:

https://github.com/openshift/release/blob/master/ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml

see: 7b49216 for example

...s/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml

kikisdeliveryservice · 2021-01-11T19:33:42Z

We don't manually generate those test files anymore... Basically you update the master.yaml file I linked to above then run:

$ make update

then fix the fields as i suggested..

omertuc · 2021-01-11T21:42:42Z

We don't manually generate those test files anymore... Basically you update the master.yaml file I linked to above then run:

$ make update

then fix the fields as i suggested..

I didn't manually generate, I put:

- as: e2e-aws-single-node
  commands: TEST_SUITE=openshift/conformance/parallel run-tests
  openshift_installer:
    cluster_profile: aws

In the config file you linked, generated, then deleted the above snippet.

The reason I deleted it is because:

- name: CLUSTER_VARIANT
- value: single-node

are manually added to the job, and they get destroyed when you try to re-generate.

If you know how I can specify the CLUSTER_VARIANT template parameter in the config file, it'll be much better, otherwise I can't think of any other solution other than removing the config that was used to generate so the snippet above doesn't get overridden.

optional and always_run that get manually modified get special treatment in that regard. The regeneration knows to skip them. The CLUSTER_VARIANT snippet however, does not.

kikisdeliveryservice · 2021-01-11T21:52:07Z

thanks @omertuc I'm just going to ask around and get this double checked before we merge. thanks for explaining.

omertuc · 2021-01-11T21:53:15Z

thanks @omertuc I'm just going to ask around and get this double checked before we merge. thanks for explaining.

Great, keep me posted.

openshift-merge-robot · 2021-01-11T22:54:15Z

@omertuc: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/pj-rehearse	c8e622ab4e6a387a6db509eff634c8d910ded403	link	`/test pj-rehearse`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kikisdeliveryservice · 2021-01-19T09:15:09Z

Will look into this later today and if I can't figure out a better solution won't block merging.

In the meantime

/retest

kikisdeliveryservice · 2021-01-19T09:31:22Z

The selection seems to be coming from :
https://docs.ci.openshift.org/docs/how-tos/contributing-openshift-release/#tolerated-changes-to-generated-jobs

@stevekuznetsov are there any major issues implementing this job as @omertuc has done ? Or we'd need to tolerate that change which seems like a bigger thing. My one concern would be - will this job get picked up for future branches too (unsure how those are generated - do they just copy master?- but prowgen was removed here)?

core-services/template-deprecation/_allowlist.yaml

kikisdeliveryservice · 2021-01-19T19:11:13Z

just adding a hold until this is updated

/hold

kikisdeliveryservice · 2021-01-27T01:18:15Z

@stevekuznetsov could you PTAL?

This seems correct to me, but should pj-reherse pass (I'm not totally sure?)

omertuc · 2021-01-27T08:22:50Z

@stevekuznetsov could you PTAL?

This seems correct to me, but should pj-reherse pass (I'm not totally sure?)

always run false, optional true. We don't expect it to pass at this point. There are still a lot of fixes needed in the various operators for this to work.

kikisdeliveryservice · 2021-01-27T18:13:46Z

@stevekuznetsov could you PTAL?
This seems correct to me, but should pj-reherse pass (I'm not totally sure?)

always run false, optional true. We don't expect it to pass at this point. There are still a lot of fixes needed in the various operators for this to work.

yes i see that 😄

but I'd like his review to double check that these tests are now fine.

kikisdeliveryservice

spoke with stevek and this is good to go.

/lgtm

kikisdeliveryservice · 2021-01-27T18:34:01Z

/hold cancel

openshift-bot · 2021-01-27T19:20:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-27T20:12:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-27T20:24:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T01:37:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T02:42:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T03:21:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T06:22:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T06:49:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T07:28:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T07:41:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T07:54:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T08:07:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T08:20:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T10:30:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T10:56:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T11:09:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T11:22:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T12:27:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T15:16:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T15:29:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T15:42:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T15:55:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

omertuc · 2021-01-28T16:10:51Z

@omertuc looks like there's an error in

prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/14756/pull-ci-openshift-release-master-ci-operator-config-metadata/1354525915652034560

That needs to be resolved?

Right, fixed now, should be okay

openshift-ci · 2021-01-28T17:07:42Z

@omertuc: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-single-node	`a7981d1`	link	`/test pj-rehearse`
ci/prow/pj-rehearse	`a7981d1`	link	`/test pj-rehearse`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kikisdeliveryservice

thanks for the update !

/lgtm

openshift-ci-robot · 2021-01-28T21:36:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/machine-config-operator/OWNERS~~ [kikisdeliveryservice]
~~ci-operator/jobs/openshift/machine-config-operator/OWNERS~~ [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-01-28T21:59:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-01-28T22:17:15Z

@omertuc: Updated the following 3 configmaps:

ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
- key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
job-config-master configmap in namespace ci at cluster api.ci using the following files:
- key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
job-config-master configmap in namespace ci at cluster app.ci using the following files:
- key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml

Details

In response to this:

Based on #15187

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from ashcrow and kikisdeliveryservice January 11, 2021 15:45

kikisdeliveryservice suggested changes Jan 11, 2021

View reviewed changes

...s/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml Outdated Show resolved Hide resolved

...s/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml Outdated Show resolved Hide resolved

openshift-ci-robot assigned kikisdeliveryservice Jan 11, 2021

omertuc force-pushed the omer/machine-config-operator-single-node branch from ca9422d to 512d401 Compare January 11, 2021 21:35

omertuc force-pushed the omer/machine-config-operator-single-node branch from 512d401 to c8e622a Compare January 11, 2021 21:51

stevekuznetsov suggested changes Jan 19, 2021

View reviewed changes

core-services/template-deprecation/_allowlist.yaml Outdated Show resolved Hide resolved

openshift-ci-robot assigned stevekuznetsov Jan 19, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2021

omertuc force-pushed the omer/machine-config-operator-single-node branch 2 times, most recently from 00a48a4 to 009f65a Compare January 27, 2021 00:05

kikisdeliveryservice approved these changes Jan 27, 2021

View reviewed changes

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 27, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2021

Run E2E AWS single node variant on machine-config-operator presubmit

a7981d1

omertuc force-pushed the omer/machine-config-operator-single-node branch from 009f65a to a7981d1 Compare January 28, 2021 16:01

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2021

kikisdeliveryservice approved these changes Jan 28, 2021

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2021

openshift-merge-robot merged commit 79d22c3 into openshift:master Jan 28, 2021

Run E2E AWS single node variant on machine-config-operator presubmit #14756

Run E2E AWS single node variant on machine-config-operator presubmit #14756

Uh oh!

Conversation

omertuc commented Jan 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kikisdeliveryservice commented Jan 11, 2021

Uh oh!

omertuc commented Jan 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kikisdeliveryservice commented Jan 11, 2021

Uh oh!

omertuc commented Jan 11, 2021

Uh oh!

openshift-merge-robot commented Jan 11, 2021

Uh oh!

kikisdeliveryservice commented Jan 19, 2021

Uh oh!

kikisdeliveryservice commented Jan 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kikisdeliveryservice commented Jan 19, 2021

Uh oh!

kikisdeliveryservice commented Jan 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omertuc commented Jan 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kikisdeliveryservice commented Jan 27, 2021

Uh oh!

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

Uh oh!

kikisdeliveryservice commented Jan 27, 2021

Uh oh!

openshift-bot commented Jan 27, 2021

Uh oh!

openshift-bot commented Jan 27, 2021

Uh oh!

openshift-bot commented Jan 27, 2021

Uh oh!

openshift-bot commented Jan 28, 2021

Uh oh!

openshift-bot commented Jan 28, 2021

Uh oh!

openshift-bot commented Jan 28, 2021

Uh oh!

openshift-bot commented Jan 28, 2021

Uh oh!

openshift-bot commented Jan 28, 2021

Uh oh!

openshift-bot commented Jan 28, 2021

Uh oh!

openshift-bot commented Jan 28, 2021

Uh oh!

openshift-bot commented Jan 28, 2021

Uh oh!

openshift-bot commented Jan 28, 2021

Uh oh!

openshift-bot commented Jan 28, 2021

Uh oh!

openshift-bot commented Jan 28, 2021

Uh oh!

openshift-bot commented Jan 28, 2021

Uh oh!

openshift-bot commented Jan 28, 2021

Uh oh!

openshift-bot commented Jan 28, 2021

Uh oh!

openshift-bot commented Jan 28, 2021

Uh oh!

omertuc commented Jan 11, 2021 •

edited

Loading

omertuc commented Jan 11, 2021 •

edited

Loading

kikisdeliveryservice commented Jan 19, 2021 •

edited

Loading

kikisdeliveryservice commented Jan 27, 2021 •

edited

Loading

omertuc commented Jan 27, 2021 •

edited

Loading