Skip to content

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Sep 11, 2018

Changes AMI to point to official CentOS AMI, updates subnet and default security group

Fixes https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_openshift-ansible/9990/pull-ci-openshift-openshift-ansible-e2e-aws/3

Requires openshift/openshift-ansible#10065 to function properly

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2018
@vrutkovs vrutkovs changed the title Openshift Ansible RHEL AWS profile: update vars WIP Openshift Ansible RHEL AWS profile: update vars Sep 12, 2018
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 12, 2018
@vrutkovs vrutkovs force-pushed the oa-aws-update-vars branch 3 times, most recently from 1f9c25f to 1fed4c4 Compare September 13, 2018 19:34
@vrutkovs vrutkovs changed the title WIP Openshift Ansible RHEL AWS profile: update vars Openshift Ansible RHEL AWS profile: update vars Sep 13, 2018
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2018
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like a vars update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this to #1496

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 14, 2018
@bbguimaraes
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2018
@openshift-merge-robot openshift-merge-robot merged commit 9bc0fd3 into openshift:master Sep 19, 2018
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: Updated the following 2 configmaps:

  • prow-job-cluster-launch-e2e-openshift-ansible configmap using the following files:
    • key cluster-launch-e2e-openshift-ansible.yaml using file ci-operator/templates/cluster-launch-e2e-openshift-ansible.yaml
  • cluster-profile-oa-aws-rhel configmap using the following files:
    • key vars.yaml using file cluster/test-deploy/openshift-ansible-aws-rhel/vars.yaml
Details

In response to this:

Changes AMI to point to official CentOS AMI, updates subnet and default security group

Fixes https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_openshift-ansible/9990/pull-ci-openshift-openshift-ansible-e2e-aws/3

Requires openshift/openshift-ansible#10065 to function properly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs deleted the oa-aws-update-vars branch January 27, 2020 11:38
derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
* agent: add config var to deploy mce

* Managed cluster image set template

* Add doc for the AGENT_DEPLOY_MCE config var

* Fixed conflicts and getReleaseImage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants