Skip to content

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Dec 18, 2020

Make sure the variable is defined even when it's not used by the test
jobs.

Signed-off-by: Rafael Fonseca [email protected]

Make sure the variable is defined even when it's not used by the test
jobs.

Signed-off-by: Rafael Fonseca <[email protected]>
@hamzy
Copy link
Contributor

hamzy commented Dec 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2020
@r4f4
Copy link
Contributor Author

r4f4 commented Dec 18, 2020

Fall out from #14346. It breaks CI for all remote libvirt jobs except 4.7 e2e.

@r4f4
Copy link
Contributor Author

r4f4 commented Dec 18, 2020

/assign @mandre

@mandre
Copy link
Member

mandre commented Dec 18, 2020

/lgtm

@mandre
Copy link
Member

mandre commented Dec 18, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hamzy, mandre, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit fc16588 into openshift:master Dec 18, 2020
@openshift-ci-robot
Copy link
Contributor

@r4f4: Updated the following 5 configmaps:

  • prow-job-cluster-launch-installer-remote-libvirt-e2e configmap in namespace ci at cluster build02 using the following files:
    • key cluster-launch-installer-remote-libvirt-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-remote-libvirt-e2e.yaml
  • prow-job-cluster-launch-installer-remote-libvirt-e2e configmap in namespace ci at cluster vsphere using the following files:
    • key cluster-launch-installer-remote-libvirt-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-remote-libvirt-e2e.yaml
  • prow-job-cluster-launch-installer-remote-libvirt-e2e configmap in namespace ci at cluster api.ci using the following files:
    • key cluster-launch-installer-remote-libvirt-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-remote-libvirt-e2e.yaml
  • prow-job-cluster-launch-installer-remote-libvirt-e2e configmap in namespace ci at cluster app.ci using the following files:
    • key cluster-launch-installer-remote-libvirt-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-remote-libvirt-e2e.yaml
  • prow-job-cluster-launch-installer-remote-libvirt-e2e configmap in namespace ci at cluster build01 using the following files:
    • key cluster-launch-installer-remote-libvirt-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-remote-libvirt-e2e.yaml
Details

In response to this:

Make sure the variable is defined even when it's not used by the test
jobs.

Signed-off-by: Rafael Fonseca [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants