Skip to content

use official rh tooling image #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 11, 2018
Merged

use official rh tooling image #1444

openshift-merge-robot merged 1 commit into from
Sep 11, 2018

Conversation

@paulfantom
Copy link
Contributor

@paulfantom paulfantom commented Sep 11, 2018

Same as #1443 but for @openshift/sig-cloud repos.

/assign @openshift/sig-cloud

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2018
trawler
trawler approved these changes Sep 11, 2018
View reviewed changes
Copy link

@trawler trawler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 11, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom, trawler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit aa26fcb into openshift:master Sep 11, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 11, 2018

@paulfantom: Updated the job-config configmap using the following files:

  • key openshift-cluster-api-provider-aws-presubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-aws/openshift-cluster-api-provider-aws-presubmits.yaml
  • key openshift-machine-api-operator-presubmits.yaml using file ci-operator/jobs/openshift/machine-api-operator/openshift-machine-api-operator-presubmits.yaml
Details

In response to this:

Same as #1443 but for @openshift/sig-cloud repos.

/assign @openshift/sig-cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@paulfantom paulfantom deleted the use_rh_tooling_image branch September 11, 2018 10:38
@paulfantom
Copy link
Contributor Author

paulfantom commented Sep 11, 2018

Oh, nice to know that /lgtm also works in review comments! 👍

derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
@bfournie
Agent-239: Use IPv6 addresses in nmstate config (openshift#1444)
0a0ad85 
For agent IPv6 testing set up the nmstate config to use IPv6
addressing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@spangenberg spangenberg Awaiting requested review from spangenberg

1 more reviewer

@trawler trawler trawler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@trawler trawler

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paulfantom @openshift-ci-robot @trawler @openshift-merge-robot